Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to py3 tool definition for pybind11 #34026

Merged
merged 1 commit into from Jun 16, 2021

Conversation

davidlange6
Copy link
Contributor

pybind11 is header only and does not depend on python directly (in the tool sense).
Requires a cmsdist upgrade.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34026/23156

  • This PR adds an extra 16KB to repository

@davidlange6
Copy link
Contributor Author

please test with cms-sw/cmsdist#6996

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CondCore/CondDB
FWCore/ParameterSetReader
FWCore/PyDevParameterSet
FWCore/PythonFramework
FWCore/PythonParameterSet

@ggovi, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @mmusich, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

please abort

@davidlange6
Copy link
Contributor Author

please test with cms-sw/cmsdist#6996

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-961ca9/15765/summary.html
COMMIT: bb57d2c
CMSSW: CMSSW_12_0_X_2021-06-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34026/15765/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-961ca9/15765/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-961ca9/15765/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2648335
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2648306
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+core
this should be merged along with cms-sw/cmsdist#6996

@davidlange6
Copy link
Contributor Author

any issues with this PR?

@smuzaffar
Copy link
Contributor

@ggovi , can you please sign it for DB?

@ggovi
Copy link
Contributor

ggovi commented Jun 15, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 16, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants