[CORE] Apply code-checks/format with misc-definitions-in-headers #34036

smuzaffar · 2021-06-08T18:50:10Z

code-checks/format applied on full cmssw

…nal check

cmsbuild · 2021-06-08T19:03:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34036/23170

This PR adds an extra 16KB to repository

cmsbuild · 2021-06-08T19:03:30Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/Common
DataFormats/Provenance
FWCore/FWLite
FWCore/Framework
FWCore/Integration
FWCore/MessageLogger
FWCore/ParameterSet
FWCore/PluginManager
FWCore/Utilities
IOPool/Common
PerfTools/EdmEvent
Utilities/StorageFactory

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

wddgit · 2021-06-08T19:23:52Z

IOPool/Common/bin/EdmProvDump.cc

+                                                                                             "nothin"
+                                                                                             "g "
+                                                                                             "else"
+                                                                                             ")");


This looks worse than it was before. Several other of the modifications look worse, although this is the worst one of all of them.

wow, auto formating :-) yes this look bad

and few other places too :-(

Do we need to format these manually (the issue appears to be related to the API of boost::program_options::options_description), or is there some automagic switch?

makortel · 2021-06-08T19:27:17Z

@cmsbuild please test

FWCore/Integration/test/AcquireIntStreamFilter.cc

cmsbuild · 2021-06-09T08:25:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f58ebc/15780/summary.html
COMMIT: bcac5f3
CMSSW: CMSSW_12_0_X_2021-06-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34036/15780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2862520
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2862485
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-06-09T14:22:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34036/23209

This PR adds an extra 112KB to repository

makortel · 2021-06-09T15:24:16Z

@cmsbuild, please test

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>

cmsbuild · 2021-06-09T16:06:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34036/23212

This PR adds an extra 144KB to repository

cmsbuild · 2021-06-09T16:06:32Z

Pull request #34036 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

smuzaffar · 2021-06-09T16:08:24Z

please test

cmsbuild · 2021-06-09T21:35:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f58ebc/15825/summary.html
COMMIT: 79930bd
CMSSW: CMSSW_12_0_X_2021-06-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34036/15825/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2862520
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2862485
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

makortel · 2021-06-10T01:17:56Z

+1

cmsbuild · 2021-06-10T01:18:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-10T03:56:12Z

+1

smuzaffar added 2 commits June 8, 2021 20:28

[CORE] Apply code-checks-all with misc-definitions-in-headers additio…

8d173f8

…nal check

[CORE] apply code-format

bcac5f3

cmsbuild added this to the CMSSW_12_0_X milestone Jun 8, 2021

cmsbuild added code-checks-pending core-pending orp-pending pending-signatures tests-pending labels Jun 8, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 8, 2021

wddgit reviewed Jun 8, 2021

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jun 8, 2021

makortel reviewed Jun 8, 2021

View reviewed changes

FWCore/Integration/test/AcquireIntStreamFilter.cc Outdated Show resolved Hide resolved

cmsbuild added tests-approved and removed tests-started labels Jun 9, 2021

smuzaffar mentioned this pull request Jun 9, 2021

[VISUALIZATION] Apply code-checks/format with misc-definitions-in-headers #34054

Merged

trun off clang format for selected sections

e45c861

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Jun 9, 2021

added clang-format exception for cmsRunPython3.cpp

d186b64

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 9, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 9, 2021

Update FWCore/Integration/test/AcquireIntStreamFilter.cc

67f608a

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Jun 9, 2021

Update AcquireIntStreamProducer.cc

79930bd

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 9, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 9, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 9, 2021

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Jun 10, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 10, 2021

cmsbuild merged commit f113f4d into cms-sw:master Jun 10, 2021

smuzaffar deleted the 12_0-code-checks-CORE branch June 15, 2021 07:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CORE] Apply code-checks/format with misc-definitions-in-headers #34036

[CORE] Apply code-checks/format with misc-definitions-in-headers #34036

smuzaffar commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

wddgit Jun 8, 2021

smuzaffar Jun 8, 2021

smuzaffar Jun 8, 2021

makortel Jun 8, 2021

makortel commented Jun 8, 2021

cmsbuild commented Jun 9, 2021

cmsbuild commented Jun 9, 2021

makortel commented Jun 9, 2021

cmsbuild commented Jun 9, 2021

cmsbuild commented Jun 9, 2021

smuzaffar commented Jun 9, 2021

cmsbuild commented Jun 9, 2021

makortel commented Jun 10, 2021

cmsbuild commented Jun 10, 2021

qliphy commented Jun 10, 2021

[CORE] Apply code-checks/format with misc-definitions-in-headers #34036

[CORE] Apply code-checks/format with misc-definitions-in-headers #34036

Conversation

smuzaffar commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

wddgit Jun 8, 2021

Choose a reason for hiding this comment

smuzaffar Jun 8, 2021

Choose a reason for hiding this comment

smuzaffar Jun 8, 2021

Choose a reason for hiding this comment

makortel Jun 8, 2021

Choose a reason for hiding this comment

makortel commented Jun 8, 2021

cmsbuild commented Jun 9, 2021

Comparison Summary

cmsbuild commented Jun 9, 2021

makortel commented Jun 9, 2021

cmsbuild commented Jun 9, 2021

cmsbuild commented Jun 9, 2021

smuzaffar commented Jun 9, 2021

cmsbuild commented Jun 9, 2021

Comparison Summary

makortel commented Jun 10, 2021

cmsbuild commented Jun 10, 2021

qliphy commented Jun 10, 2021