Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

adewit · 2021-06-14T20:14:06Z

PR description:

This adds a phase 2 tracker geometry (T27) containing bricked pixels in TEPX&TFPX, as well as the central 1 (3) rod(s) of TBPX L2 (L3 and 4). Because the information about whether a pixel is "bricked" or not should be available at the level of the geometry, a new record to store this information has also been added, as discussed in these slides. Note that wrt that presentation, the record has been renamed PTrackerAdditionalParametersPerDetRcd, and it has been made expandable to make it possible to add further bool/int/float per-detID information for the tracker in the future.
For now the record is created from the XML, as no Phase 2 geometries are stored in the DB, but a DB writer is also included for future use.

NOTE: the new record PTrackerAdditionalParametersPerDetRcd is consumed by the TrackerGeomBuilderFromGeometricDet, which is the same for Runs 2&3 and Phase 2. Therefore this PR also modifies Runs 2&3, by including the new record, which however only contains the default value (False) for the brickedness boolean, as this parameter of course does not exist before Phase 2

The new tracker geometry T27 that uses the bricked pixels is part of detector D85. The workflows for D85 only run up to and including the digitization step to avoid having to include changes in the reconstruction code at this point. NOTE: the modifications to the digitzer that are needed to handle bricked pixels are NOT included in this PR ( @franzglessgen will provide that in due course). In the current state the standard digitizer for planar pixels will be used; this is of course not the final configuration but it does not lead to problems.

@emiglior @mmusich fyi

PR validation:

Checked that the addition of the new rcd does not break non-Phase2 workflows (checked for a few workflows)
Checked that the information on the brickedness of the pixels is passed on as expected
Verified that the DB writer is working

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

cmsbuild · 2021-06-14T20:22:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34120/23314

This PR adds an extra 828KB to repository
Found files with invalid states:
- CondFormats/GeometryObjects/src/PTrackerPhase2ITParameters.cc:
  - Added: f3f7ffe
  - Modified: 12b249b
  - Deleted: e2731cd
- CondFormats/GeometryObjects/interface/PTrackerPhase2ITParameters.h:
  - Added: f3f7ffe
  - Modified: 12b249b
  - Deleted: e2731cd
- Geometry/Records/interface/PTrackerPhase2ITParametersRcd.h:
  - Added: f3f7ffe
  - Modified: 12b249b
  - Deleted: e2731cd
- Configuration/Geometry/python/log_TrackerGeometricDetExtra:
  - Added: e2731cd
  - Deleted: b700ccf
- CondFormats/GeometryObjects/interface/PTrackerGeometricDetExtra.h:
  - Added: 03421d4
  - Deleted: f3f7ffe
- Geometry/Records/interface/PTrackerGeometricDetExtraRcd.h:
  - Added: 03421d4
  - Deleted: f3f7ffe
- Geometry/TrackerGeometryBuilder/interface/TrackerGeomBuilderFromGeometricDetTEST.h:
  - Added: f37fd0f
  - Deleted: 03421d4
- Configuration/Geometry/python/allgeoms.log:
  - Added: e2731cd
  - Deleted: b700ccf
- Geometry/Records/interface/PGeometricDetExtraRcd.h:
  - Added: f37fd0f
  - Deleted: 03421d4
- Geometry/TrackerGeometryBuilder/plugins/TrackerPhase2ITParametersESModule.cc:
  - Added: f3f7ffe
  - Modified: 12b249b
  - Deleted: e2731cd
- Geometry/Records/src/PTrackerPhase2ITParametersRcd.cc:
  - Added: f3f7ffe
  - Deleted: e2731cd
- CondFormats/GeometryObjects/src/T_EventSetup_PTrackerGeometricDetExtra.cc:
  - Added: 03421d4
  - Deleted: f3f7ffe
- CondFormats/GeometryObjects/src/T_EventSetup_PGeometricDetExtra.cc:
  - Added: f37fd0f
  - Deleted: 03421d4
- Geometry/TrackerGeometryBuilder/plugins/GeometricDetExtraESModule.cc:
  - Added: f37fd0f
  - Deleted: 03421d4
- Geometry/TrackerGeometryBuilder/src/TrackerGeomBuilderFromGeometricDetTEST.cc:
  - Added: f37fd0f
  - Deleted: 03421d4
- Geometry/Records/src/PGeometricDetExtraRcd.cc:
  - Added: f37fd0f
  - Deleted: 03421d4
- Geometry/TrackerGeometryBuilder/plugins/TrackerGeometricDetExtraESModule.cc:
  - Added: 03421d4
  - Modified: 88c37a0
  - Deleted: 8782d0c
- Configuration/Geometry/python/allGeomConfigs.log:
  - Added: e2731cd
  - Deleted: b700ccf
- CondFormats/GeometryObjects/interface/PGeometricDetExtra.h:
  - Added: f37fd0f
  - Deleted: 03421d4
- CondFormats/GeometryObjects/src/T_EventSetup_PTrackerPhase2ITParameters.cc:
  - Added: f3f7ffe
  - Deleted: e2731cd
- Configuration/Geometry/python/log_TrackerRecoGeometryESProducer:
  - Added: e2731cd
  - Deleted: b700ccf
- CondTools/Geometry/plugins/PTrackerPhase2ITParametersDBBuilder.cc:
  - Added: 76c1420
  - Modified: 12b249b
  - Deleted: e2731cd
- Geometry/Records/src/PTrackerGeometricDetExtraRcd.cc:
  - Added: 03421d4
  - Deleted: f3f7ffe
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc modified in PR(s): Migrate to esConsumes HIP and MillePede Alignment Algorithms #33583
- File Configuration/Geometry/README.md modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File Configuration/Geometry/python/GeometryDD4hepExtended2026D83Reco_cff.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File Configuration/Geometry/python/GeometryExtended2026D83Reco_cff.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File Configuration/Geometry/python/dict2021Geometry.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548, Run3-gex77 Remove reference to duplicated vaccum #34101
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548, update the tracking material for Phase2 geometry D49 #30126
- File Configuration/PyReleaseValidation/python/relval_2026.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548, Temporary eventcontent needed for Phase-2 RECO when RAWSIM is used as input #33972, Add run3 tracking low pu era #33532, Update MkFit to support multiple iterations #33802
- File Configuration/StandardSequences/python/GeometryConf.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548

cmsbuild · 2021-06-14T20:25:54Z

A new Pull Request was created by @adewit for master.

It involves the following packages:

Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentProducer
Alignment/LaserAlignment
Alignment/MillePedeAlignmentAlgorithm
Alignment/OfflineValidation
Alignment/SurveyAnalysis
Alignment/TrackerAlignment
CondCore/GeometryPlugins
CondCore/Utilities
CondFormats/GeometryObjects
CondTools/Geometry
Configuration/AlCa
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/CommonTopologies
Geometry/MTDGeometryBuilder
Geometry/Records
Geometry/TrackerCommonData
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder

@chayanit, @wajidalikhan, @ianna, @kpedro88, @tlampen, @pohsun, @civanch, @yuanchao, @silviodonato, @cmsbuild, @davidlange6, @Dr15Jones, @cvuosalo, @mdhildreth, @ggovi, @qliphy, @fabiocos, @francescobrivio, @malbouis, @jordan-martins, @makortel, @srimanob can you please review it and eventually sign? Thanks.
@felicepantaleo, @ghugo83, @Martin-Grunewald, @tlampen, @mmusich, @slomeo, @venturia, @pakhotin, @vargasa, @makortel, @JanFSchulte, @dgulhan, @seemasharmafnal, @cvuosalo, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @ebrondol, @mtosi, @fabiocos, @lecriste this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2021-06-14T20:31:01Z

@cmsbuild, please test

cmsbuild · 2021-06-15T00:31:09Z

-1

Failed Tests: UnitTests AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f0f25/15948/summary.html
COMMIT: 7213ad3
CMSSW: CMSSW_12_0_X_2021-06-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34120/15948/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f0f25/15948/llvm-analysis/cmsclangtidy.txt for details.

Unit Tests

I found errors in the following unit tests:

---> test GeometryDOMCount had ERRORS
---> test GeometryTrackerGeometryBuilderTestDriver had ERRORS
---> test testTauEmbeddingProducers had ERRORS

AddOn Tests

hlt_mc_PRef

----- Begin Fatal Exception 14-Jun-2021 23:49:32 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Running EventSetup component TrackerDigiGeometryESModule/'
   [1] While getting dependent Record from Record TrackerDigiGeometryRecord
Exception Message:
No "PTrackerAdditionalParametersPerDetRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 14-Jun-2021 23:50:07 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Running EventSetup component TrackerDigiGeometryESModule/'
   [1] While getting dependent Record from Record TrackerDigiGeometryRecord
Exception Message:
No "PTrackerAdditionalParametersPerDetRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 14-Jun-2021 23:50:10 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Running EventSetup component TrackerDigiGeometryESModule/'
   [1] While getting dependent Record from Record TrackerDigiGeometryRecord
Exception Message:
No "PTrackerAdditionalParametersPerDetRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2862520
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2862491
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

mmusich · 2021-06-15T08:30:46Z

---> test testTauEmbeddingProducers had ERRORS

this is spurious and due to issue #34112.
All the rest of failures are real.

adewit · 2021-06-15T09:38:57Z

---> test testTauEmbeddingProducers had ERRORS

this is spurious and due to issue #34112.
All the rest of failures are real.

Thanks - I understand all the rest of them apart from the GeometryDOMCount one, which works locally :/

mmusich · 2021-06-14T20:49:10Z

CondTools/Geometry/plugins/PTrackerAdditionalParametersPerDetDBBuilder.cc

+  }
+
+  edm::ESTransientHandle<GeometricDet> gd;
+  es.get<IdealGeometryRecord>().get(gd);


please use esConsumes here.

mmusich · 2021-06-15T16:15:24Z

HLTrigger/Configuration/test/OnLine_HLT_PIon.py

@@ -4001,6 +4001,7 @@
  applyAlignment = cms.bool( True ),
  alignmentsLabel = cms.string( "" )
 )
+process.TrackerAdditionalParametersPerDetESModule = cms.ESProducer("TrackerAdditionalParametersPerDetESModule")


@adewit, direct modification of the HLT menu are disallowed as per TSG policy.
Please add a customization function in customizeHLTforCMSSW

adewit · 2021-06-15T16:17:34Z

---> test GeometryDOMCount had ERRORS

After investigation I don't think this one is related to this PR; the IB CMSSW_12_0_X_2021-06-14-1100 is missing the package DetectorDescription/Schema, and that's why this test fails.

mmusich · 2021-07-28T08:22:16Z

and (2) that the PR #34542 got merged which now leads to a merge conflict.

@tvami I don't see any merge conflict:

cmsbuild · 2021-07-28T12:09:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f0f25/17287/summary.html
COMMIT: c05d615
CMSSW: CMSSW_12_0_X_2021-07-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34120/17287/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f0f25/17287/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7f0f25/38634.0_TTbar_14TeV+2026D86+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7f0f25/39034.0_TTbar_14TeV+2026D87+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998529
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

srimanob · 2021-07-28T12:16:29Z

For the recording, do you plan to fix the warning,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f0f25/17287/llvm-analysis/legacy-mod-sa.txt
in later PR? Sorry, it was mentioned somewhere in this long PR.

@adewit @mmusich

srimanob · 2021-07-28T12:16:57Z

@cms-sw/db-l2 Could you please consider and sign if everything is OK from your side? Big thanks.

ggovi · 2021-07-28T12:28:32Z

+1

qliphy · 2021-07-28T12:36:30Z

+operations

qliphy · 2021-07-28T12:36:37Z

+1

cmsbuild · 2021-07-28T12:37:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

mmusich · 2021-07-29T10:49:06Z

@srimanob

For the recording, do you plan to fix the warning,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f0f25/17287/llvm-analysis/legacy-mod-sa.txt
in later PR? Sorry, it was mentioned somewhere in this long PR.

Addressed at #34690

cmsbuild added this to the CMSSW_12_0_X milestone Jun 14, 2021

cmsbuild added alca-pending code-checks-pending db-pending geometry-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Jun 14, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 14, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 14, 2021

cmsbuild added tests-rejected and removed tests-started labels Jun 15, 2021

cmsbuild added code-checks-pending hlt-pending tests-pending and removed code-checks-approved tests-rejected labels Jun 15, 2021

mmusich suggested changes Jun 15, 2021

View reviewed changes

cmsbuild added tests-started and removed tests-rejected labels Jul 28, 2021

cmsbuild mentioned this pull request Jul 28, 2021

Update DT DQM, calibration scripts, and local reco code to allow using "new" DB format #34612

Merged

cmsbuild added tests-approved and removed tests-started labels Jul 28, 2021

cmsbuild added db-approved and removed db-pending labels Jul 28, 2021

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending orp-pending pending-signatures labels Jul 28, 2021

cmsbuild merged commit 2ae8494 into cms-sw:master Jul 28, 2021

cmsbuild mentioned this pull request Jul 28, 2021

DQM Pixel Phase 1: Several new Efficiency trend plots #34384

Merged

mmusich mentioned this pull request Jul 29, 2021

make TrackerSystematicMisalignments a one module #34690

Merged

adewit mentioned this pull request Jul 29, 2021

Adding T27 (OT800_IT800) tkLayout/tkLayout#569

Merged

This was referenced Sep 6, 2021

Addition of Bricked Pixel Algorithm in Phase2 Tracker Digitizer #35160

Closed

Tracker Phase2 Digitizer framework update for BrickedPixel #35173

Merged

cvuosalo mentioned this pull request Sep 7, 2021

Add TrackerAdditionalParametersPerDet_cfi to prevent exception in Tracker test script #35183

Merged

emiglior mentioned this pull request Mar 28, 2024

introducing BigPixel for phase-2 InnerTracker in T39 geometry #44576

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

adewit commented Jun 14, 2021 •

edited

cmsbuild commented Jun 14, 2021

cmsbuild commented Jun 14, 2021

mmusich commented Jun 14, 2021

cmsbuild commented Jun 15, 2021

mmusich commented Jun 15, 2021

adewit commented Jun 15, 2021

mmusich Jun 14, 2021

adewit Jun 15, 2021

mmusich Jun 15, 2021

adewit Jun 15, 2021

adewit commented Jun 15, 2021

mmusich commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

srimanob commented Jul 28, 2021

srimanob commented Jul 28, 2021 •

edited

ggovi commented Jul 28, 2021

qliphy commented Jul 28, 2021

qliphy commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

mmusich commented Jul 29, 2021

Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

Conversation

adewit commented Jun 14, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 14, 2021

cmsbuild commented Jun 14, 2021

mmusich commented Jun 14, 2021

cmsbuild commented Jun 15, 2021

Unit Tests

AddOn Tests

Comparison Summary

mmusich commented Jun 15, 2021

adewit commented Jun 15, 2021

mmusich Jun 14, 2021

Choose a reason for hiding this comment

adewit Jun 15, 2021

Choose a reason for hiding this comment

mmusich Jun 15, 2021

Choose a reason for hiding this comment

adewit Jun 15, 2021

Choose a reason for hiding this comment

adewit commented Jun 15, 2021

mmusich commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

Comparison Summary

srimanob commented Jul 28, 2021

srimanob commented Jul 28, 2021 • edited

ggovi commented Jul 28, 2021

qliphy commented Jul 28, 2021

qliphy commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

mmusich commented Jul 29, 2021

adewit commented Jun 14, 2021 •

edited

srimanob commented Jul 28, 2021 •

edited