add unit tests for getPayloadData.py #34199

mmusich · 2021-06-21T17:33:53Z

PR description:

This is a follow-up to issue #34193.
Added a unit test to avoid having to find post-facto that the getPayloadData script employed by the CondDB Browser is broken.

PR validation:

Tried to run the new uni test, which fails as reported at #34193 (comment).
The commands included in CondCore/Utilities/test/test_getPayloadData.sh were successfully executed in CMSSW_12_0_0_pre2.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

cmsbuild · 2021-06-21T17:39:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34199/23421

This PR adds an extra 16KB to repository

cmsbuild · 2021-06-21T17:39:48Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

qliphy · 2021-06-22T00:50:49Z

please test

cmsbuild · 2021-06-22T03:49:56Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5f44a/16151/summary.html
COMMIT: a955dfb
CMSSW: CMSSW_12_0_X_2021-06-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34199/16151/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testGetPayloadData had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2785631
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2785608
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-06-22T07:32:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34199/23426

This PR adds an extra 12KB to repository

cmsbuild · 2021-06-22T07:33:20Z

Pull request #34199 was updated. @ggovi, @cmsbuild can you please check and sign again.

CondCore/Utilities/test/BuildFile.xml

cmsbuild · 2021-06-23T14:46:07Z

Pull request #34199 was updated. @ggovi, @cmsbuild can you please check and sign again.

mmusich · 2021-06-23T14:51:41Z

@cmsbuild please test

cmsbuild · 2021-06-23T17:48:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5f44a/16193/summary.html
COMMIT: 50c6bd6
CMSSW: CMSSW_12_0_X_2021-06-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34199/16193/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2785631
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2785602
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

mmusich · 2021-06-25T12:53:34Z

@ggovi any (further) objection to this PR?

ggovi · 2021-06-25T12:59:14Z

+1

cmsbuild · 2021-06-25T12:59:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-25T15:36:09Z

+1

qliphy · 2021-06-26T07:10:55Z

@mmusich There is a unit failure in most recent IB after this PR is merged. Can you have a check? Thanks!

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_0_X_2021-06-25-2300/unitTestLogs/CondCore/Utilities#/181-181
Traceback (most recent call last):
File "", line 1, in
KeyError: 'cond::BasicPayload'
getPayloadData.py --discover test not passed... found no entries

mmusich · 2021-06-26T09:12:35Z

@qliphy I cannot reproduce the issue:

cmsrel CMSSW_12_0_X_2021-06-25-2300
cd CMSSW_12_0_X_2021-06-25-2300/src/
cmsenv
git cms-addpkg CondCore/Utilities
scram b -j 20
scram b runtests_testGetPayloadData
...

---> test testGetPayloadData succeeded
TestTime:80
^^^^ End Test testGetPayloadData ^^^^

isn't the package compiled before executing the unit test in the IB?

smuzaffar · 2021-06-26T09:35:26Z

@mmusich , in IB getPayloadData.py --discover returned empty results ( i.e. {} ) e.g.

scram p CMSSW_12_0_X_2021-06-25-2300
cd CMSSW_12_0_X_2021-06-25-2300
cmsenv
getPayloadData.py --discover

could it be that the https://github.com/cms-sw/cmssw/blob/master/CondCore/CondDB/plugins/CondDBPyWrappers.cc#L11-L14 is looking in to only local edmplugin information? Note that for IB unit tests we just create a local dev area and run without re-compilation , so every thing should be picked up from release area.

mmusich · 2021-06-26T09:59:11Z

@smuzaffar so substantially my question about:

isn't the package compiled before executing the unit test in the IB?

is no.
Anyway I've already found that out, see #34257

smuzaffar · 2021-06-26T09:59:55Z

I think problem is https://github.com/cms-sw/cmssw/blob/master/CondCore/Utilities/scripts/getPayloadData.py#L140 , it breaks on first release path. I think it should go through all the paths (specially if there are no plugins found ). As I wrote, for IBs, we just create an empty cmssw area, so the lib direcotry in that will be empty.

Please also add CMSSW_FULL_RELEASE_BASE in the release list https://github.com/cms-sw/cmssw/blob/master/CondCore/Utilities/scripts/getPayloadData.py#L125 . This will allow the script to work if it is running in a patch release

smuzaffar · 2021-06-26T10:00:46Z

ah thanks for #34257 :-) please also add CMSSW_FULL_RELEASE_BASE

qliphy · 2021-07-16T03:15:10Z

See #34512

cmsbuild added this to the CMSSW_12_0_X milestone Jun 21, 2021

cmsbuild added code-checks-pending db-pending orp-pending pending-signatures tests-pending labels Jun 21, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 21, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2021

cmsbuild added tests-rejected and removed tests-started labels Jun 22, 2021

mmusich force-pushed the getPayloadDataUnitTest branch from a955dfb to 1a1224a Compare June 22, 2021 07:13

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels Jun 22, 2021

mmusich changed the title ~~modify getPayloadData to comply with python3 and add unit tests~~ add unit tests for getPayloadData.py Jun 22, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 22, 2021

smuzaffar reviewed Jun 22, 2021

View reviewed changes

CondCore/Utilities/test/BuildFile.xml Outdated Show resolved Hide resolved

mmusich force-pushed the getPayloadDataUnitTest branch from 1a1224a to ad89464 Compare June 22, 2021 09:22

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 22, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 23, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 23, 2021

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jun 25, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 25, 2021

cmsbuild merged commit 5d92665 into cms-sw:master Jun 25, 2021

mmusich deleted the getPayloadDataUnitTest branch June 25, 2021 20:45

cmsbuild mentioned this pull request Jun 25, 2021

"is not" -> "!=" in PatAlgos trigTools.py #34253

Merged

mmusich mentioned this pull request Jun 26, 2021

getPayloadData unit test, if no plugins are found, look in the CMSSW_RELEASE_BASE #34257

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add unit tests for getPayloadData.py #34199

add unit tests for getPayloadData.py #34199

mmusich commented Jun 21, 2021 •

edited

cmsbuild commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

qliphy commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

cmsbuild commented Jun 23, 2021

mmusich commented Jun 23, 2021

cmsbuild commented Jun 23, 2021

mmusich commented Jun 25, 2021

ggovi commented Jun 25, 2021

cmsbuild commented Jun 25, 2021

qliphy commented Jun 25, 2021

qliphy commented Jun 26, 2021

mmusich commented Jun 26, 2021

smuzaffar commented Jun 26, 2021

mmusich commented Jun 26, 2021

smuzaffar commented Jun 26, 2021 •

edited

smuzaffar commented Jun 26, 2021

qliphy commented Jul 16, 2021

add unit tests for getPayloadData.py #34199

add unit tests for getPayloadData.py #34199

Conversation

mmusich commented Jun 21, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 21, 2021

cmsbuild commented Jun 21, 2021

qliphy commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

Unit Tests

Comparison Summary

cmsbuild commented Jun 22, 2021

cmsbuild commented Jun 22, 2021

cmsbuild commented Jun 23, 2021

mmusich commented Jun 23, 2021

cmsbuild commented Jun 23, 2021

Comparison Summary

mmusich commented Jun 25, 2021

ggovi commented Jun 25, 2021

cmsbuild commented Jun 25, 2021

qliphy commented Jun 25, 2021

qliphy commented Jun 26, 2021

mmusich commented Jun 26, 2021

smuzaffar commented Jun 26, 2021

mmusich commented Jun 26, 2021

smuzaffar commented Jun 26, 2021 • edited

smuzaffar commented Jun 26, 2021

qliphy commented Jul 16, 2021

mmusich commented Jun 21, 2021 •

edited

smuzaffar commented Jun 26, 2021 •

edited