ECAL esConsumes migrations in EventFilter and RecoLocalCalo

[thomreis]

PR description:

esConsumes migrations of remaining EventSetupRecord::get occurrences in EventFilter/EcalRawToDigi and RecoLocalCalo/EcalRecProducers.

PR validation:

Complies and passes 136.874.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34273/23573

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

EventFilter/EcalRawToDigi
RecoLocalCalo/EcalRecProducers

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @Martin-Grunewald, @apsallid, @thomreis, @simonepigazzini this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cbc5d/16290/summary.html
COMMIT: 8460bfe
CMSSW: CMSSW_12_0_X_2021-06-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34273/16290/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2785682
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[sroychow]

@thomreis I have marked the google doc with this PR info. In future if you are migrating other modules, please update the doc.

[thomreis]

Thanks @sroychow I will update the doc for future migrations.

[slava77]

are the handles actually needed? It seems like their usefulness is only as a temporary to be immediately dereferenced.
getData here seems more appropriate.

   auto const& adcToGeVConstantProduct = setup.getData(tokenADCToGeVConstant_).getProduct(ctx.stream());

please check and cleanup.

[thomreis]

Only two of those are needed. I will replace the rest with getData().

[slava77]

Only two of those are needed. I will replace the rest with getData().

thank you.

the remaining two are used only locally and could as well be defined just in the ::acquire method itself.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34273/23615

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #34273 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cbc5d/16368/summary.html
COMMIT: 2763d63
CMSSW: CMSSW_12_0_X_2021-06-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34273/16368/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2785676
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34273 2763d63

• code changes are in line with the PR description and (mostly) with the follow up review
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1