change default cmsRun to use python3.

[davidlange6]

And Remove now obsolete FWCore/PyDevParameterSet package

[davidlange6]

test parameters:

• full_cmssw = true

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34300/23627

• This PR adds an extra 12KB to repository

[davidlange6]

please test

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

FWCore/Framework
FWCore/PyDevParameterSet
FWCore/PythonParameterSet

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8b770/16383/summary.html
COMMIT: fe08cad
CMSSW: CMSSW_12_0_X_2021-06-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34300/16383/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestFWCorePythonFrameworkDriver had ERRORS
---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5144 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785688
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[davidlange6]

test_parameters:

[davidlange6]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34300/23643

• This PR adds an extra 12KB to repository

[smuzaffar]

test parameters:

[smuzaffar]

please test
re-start the tests as there was a typo in last "test_parameters"

[davidlange6]

ok, great - the unit tests passed this time.

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8b770/16402/summary.html
COMMIT: b1c0ca6
CMSSW: CMSSW_12_0_X_2021-07-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34300/16402/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

[davidlange6]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8b770/16415/summary.html
COMMIT: b1c0ca6
CMSSW: CMSSW_12_0_X_2021-07-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34300/16415/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5124 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785676
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[makortel]

@davidlange6 The "Reco comparison" differences seem to be in slimmed jets pairDiscriVector. Do you know if these are caused by element order in dictionaries (e.g. cms.PSet) changing between py2 and py3?

[davidlange6]

iirc, they are caused by the reco comparison scripts assuming that keys come out of a dict in a certain order.

…

On Jul 6, 2021, at 6:31 PM, Matti Kortelainen ***@***.***> wrote: @davidlange6 The "Reco comparison" differences seem to be in slimmed jets pairDiscriVector. Do you know if these are caused by element order in dictionaries (e.g. cms.PSet) changing between py2 and py3? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[makortel]

I inspected the MiniAOD file from the reference and the PR test for workflow 4.53, and indeed the order of elements in pairDiscriVector are different between the two. The full PY3 release has passed validation, so further inspection is likely not needed.

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

urgent

@qliphy @perrotta @silviodonato As mentioned in ORP, it would be useful to have this PR in pre4

[qliphy]

+1