Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move scripts in Utilties and Validation to py3 #34364

Merged
merged 3 commits into from Jul 7, 2021

Conversation

davidlange6
Copy link
Contributor

I do not believe that anything changed is used in unit tests...

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34364/23739

  • This PR adds an extra 100KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Utilities/ReleaseScripts
Validation/HGCalValidation
Validation/RecoTrack

@smuzaffar, @andrius-k, @Dr15Jones, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @makortel, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @wddgit, @sethzenz, @apsallid, @makortel, @felicepantaleo, @wmtford, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @cseez, @bsunanda, @ebrondol, @pfs, @lecriste, @hatakeyamak, @mmusich, @lgray, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

as @smuzaffar suggested I ran python3 -m compileall on these and fixed the corresponding problems.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34364/23742

  • This PR adds an extra 100KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

Pull request #34364 was updated. @smuzaffar, @andrius-k, @Dr15Jones, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @makortel, @jfernan2, @rvenditti can you please check and sign again.

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34364/23752

  • This PR adds an extra 104KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

Pull request #34364 was updated. @smuzaffar, @andrius-k, @Dr15Jones, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @makortel, @jfernan2, @rvenditti can you please check and sign again.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfe12e/16519/summary.html
COMMIT: 3087a8a
CMSSW: CMSSW_12_0_X_2021-07-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34364/16519/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Jul 7, 2021

+1

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 7, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants