Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DQM] Add dqmPerLSsaving modifier #34487

Merged
merged 4 commits into from Jul 18, 2021
Merged

[DQM] Add dqmPerLSsaving modifier #34487

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a83346
Add perLSsaving modifier
jfernan2 Jul 14, 2021
857fdc9
Renamed to dqmPerLSsaving
jfernan2 Jul 14, 2021
99b63ed
Typo in ALCARECOHcalCalDQMHI_cff
jfernan2 Jul 15, 2021
3fe8ed2
Restore original configuration for ECAL
jfernan2 Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions Configuration/ProcessModifiers/python/perLSsaving_cff.py
View file
Open in desktop
@@ -0,0 +1,4 @@
import FWCore.ParameterSet.Config as cms

# This modifier sets the perLS saving in process.DQMStore.saveByLumi for nanoDQMIO
perLSsaving = cms.Modifier()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about e.g. dqmPerLSSaving to make it clear that the Modifier is related to DQM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks for the suggestion!

6 changes: 3 additions & 3 deletions DQM/BeamMonitor/python/AlcaBeamMonitorHeavyIons_cff.py
View file
Open in desktop
Expand Up @@ -8,9 +8,9 @@
AlcaBeamMonitor.BeamFitter.TrackQuality = ['highPurity']
AlcaBeamMonitor.PVFitter.VertexCollection = 'hiSelectedVertex'
#Check if perLSsaving is enabled to mask MEs vs LS
from DQMServices.Core.DQMStore_cfi import DQMStore
if(DQMStore.saveByLumi):
AlcaBeamMonitor.perLSsaving=True
from Configuration.ProcessModifiers.perLSsaving_cff import perLSsaving
perLSsaving.toModify(AlcaBeamMonitor, perLSsaving=True)

import RecoVertex.BeamSpotProducer.BeamSpotOnline_cfi
scalerBeamSpot = RecoVertex.BeamSpotProducer.BeamSpotOnline_cfi.onlineBeamSpotProducer.clone()
alcaBeamMonitor = cms.Sequence( scalerBeamSpot*AlcaBeamMonitor )
Expand Down
5 changes: 2 additions & 3 deletions DQM/BeamMonitor/python/AlcaBeamMonitor_cff.py
View file
Open in desktop
Expand Up @@ -2,9 +2,8 @@

from DQM.BeamMonitor.AlcaBeamMonitor_cfi import *
#Check if perLSsaving is enabled to mask MEs vs LS
from DQMServices.Core.DQMStore_cfi import DQMStore
if(DQMStore.saveByLumi):
AlcaBeamMonitor.perLSsaving=True
from Configuration.ProcessModifiers.perLSsaving_cff import perLSsaving
perLSsaving.toModify(AlcaBeamMonitor, perLSsaving=True)

import RecoVertex.BeamSpotProducer.BeamSpotOnline_cfi
scalerBeamSpot = RecoVertex.BeamSpotProducer.BeamSpotOnline_cfi.onlineBeamSpotProducer.clone()
Expand Down
9 changes: 4 additions & 5 deletions DQM/CTPPS/python/ctppsDQM_cff.py
View file
Open in desktop
Expand Up @@ -50,11 +50,10 @@
)

#Check if perLSsaving is enabled to mask MEs vs LS
from DQMServices.Core.DQMStore_cfi import DQMStore
if(DQMStore.saveByLumi):
ctppsDiamondDQMSource.perLSsaving=True
totemTimingDQMSource.perLSsaving=True
ctppsCommonDQMSourceOffline.perLSsaving=True
from Configuration.ProcessModifiers.perLSsaving_cff import perLSsaving
perLSsaving.toModify(ctppsDiamondDQMSource, perLSsaving=True)
perLSsaving.toModify(totemTimingDQMSource, perLSsaving=True)
perLSsaving.toModify(ctppsCommonDQMSourceOffline, perLSsaving=True)

_ctppsDQMOfflineSource = cms.Sequence(
ctppsPixelDQMOfflineSource
Expand Down
6 changes: 3 additions & 3 deletions DQM/EcalPreshowerMonitorModule/python/es_dqm_source_offline_cff.py
View file
Open in desktop
Expand Up @@ -3,9 +3,9 @@
from DQM.EcalPreshowerMonitorModule.ESRawDataTask_cfi import *
from DQM.EcalPreshowerMonitorModule.ESIntegrityTask_cfi import *
#Check if perLSsaving is enabled to mask MEs vs LS
from DQMServices.Core.DQMStore_cfi import DQMStore
if(not DQMStore.saveByLumi):
ecalPreshowerIntegrityTask.DoLumiAnalysis = True
from Configuration.ProcessModifiers.perLSsaving_cff import perLSsaving
perLSsaving.toModify(ecalPreshowerIntegrityTask, DoLumiAnalysis = False)

from DQM.EcalPreshowerMonitorModule.ESFEDIntegrityTask_cfi import *
from DQM.EcalPreshowerMonitorModule.ESOccupancyTask_cfi import *
from DQM.EcalPreshowerMonitorModule.ESTrendTask_cfi import *
Expand Down
5 changes: 2 additions & 3 deletions DQM/L1TMonitor/python/L1TEmulatorMonitor_cff.py
View file
Open in desktop
Expand Up @@ -38,9 +38,8 @@

from DQM.L1TMonitor.L1TdeRCT_cfi import *
#Check if perLSsaving is enabled to mask MEs vs LS
from DQMServices.Core.DQMStore_cfi import DQMStore
if(DQMStore.saveByLumi):
l1TdeRCT.perLSsaving=True
from Configuration.ProcessModifiers.perLSsaving_cff import perLSsaving
perLSsaving.toModify(l1TdeRCT, perLSsaving=True)

l1TdeRCTRun1 = l1TdeRCT.clone()
l1TdeRCT.rctSourceData = 'caloStage1Digis'
Expand Down
5 changes: 2 additions & 3 deletions DQM/SiPixelCommon/python/SiPixelOfflineDQM_source_cff.py
View file
Open in desktop
Expand Up @@ -116,9 +116,8 @@
)

#Check if perLSsaving is enabled to mask MEs vs LS
from DQMServices.Core.DQMStore_cfi import DQMStore
if(DQMStore.saveByLumi):
SiPixelDigiSource.perLSsaving=True
from Configuration.ProcessModifiers.perLSsaving_cff import perLSsaving
perLSsaving.toModify(SiPixelDigiSource, perLSsaving=True)

#FED integrity
from DQM.SiPixelMonitorRawData.SiPixelMonitorHLT_cfi import *
Expand Down
5 changes: 2 additions & 3 deletions DQMOffline/Configuration/python/ALCARECOHcalCalDQMHI_cff.py
View file
Open in desktop
Expand Up @@ -7,9 +7,8 @@
import DQMOffline.CalibCalo.MonitorHOAlCaRecoStream_cfi

#Check if perLSsaving is enabled to mask MEs vs LS
from DQMServices.Core.DQMStore_cfi import DQMStore
if(DQMStore.saveByLumi):
DQMOffline.CalibCalo.MonitorAlCaHcalPhisym_cfi.HcalPhiSymMon.perLSsaving=True
from Configuration.ProcessModifiers.perLSsavin_cff import perLSsaving
perLSsaving.toModify(DQMOffline.CalibCalo.MonitorAlCaHcalPhisym_cfi.HcalPhiSymMon, perLSsaving=True)

ALCARECOHcalCalPhisymDQM = DQMOffline.CalibCalo.MonitorAlCaHcalPhisym_cfi.HcalPhiSymMon.clone()

Expand Down
5 changes: 2 additions & 3 deletions DQMOffline/Configuration/python/ALCARECOHcalCalDQM_cff.py
View file
Open in desktop
Expand Up @@ -7,9 +7,8 @@
import DQMOffline.CalibCalo.MonitorHOAlCaRecoStream_cfi

#Check if perLSsaving is enabled to mask MEs vs LS
from DQMServices.Core.DQMStore_cfi import DQMStore
if(DQMStore.saveByLumi):
DQMOffline.CalibCalo.MonitorAlCaHcalPhisym_cfi.HcalPhiSymMon.perLSsaving=True
from Configuration.ProcessModifiers.perLSsaving_cff import perLSsaving
perLSsaving.toModify(DQMOffline.CalibCalo.MonitorAlCaHcalPhisym_cfi.HcalPhiSymMon, perLSsaving=True)

ALCARECOHcalCalPhisymDQM = DQMOffline.CalibCalo.MonitorAlCaHcalPhisym_cfi.HcalPhiSymMon.clone()

Expand Down
5 changes: 2 additions & 3 deletions DQMOffline/Trigger/python/DQMOffline_Trigger_cff.py
View file
Open in desktop
Expand Up @@ -72,9 +72,8 @@
# photon jet
from DQMOffline.Trigger.HigPhotonJetHLTOfflineSource_cfi import * # ?!?!?!
#Check if perLSsaving is enabled to mask MEs vs LS
from DQMServices.Core.DQMStore_cfi import DQMStore
if(DQMStore.saveByLumi):
higPhotonJetHLTOfflineSource.perLSsaving=True
from Configuration.ProcessModifiers.perLSsaving_cff import perLSsaving
perLSsaving.toModify(higPhotonJetHLTOfflineSource, perLSsaving=True)
# SMP
from DQMOffline.Trigger.StandardModelMonitoring_cff import *

Expand Down