Migrate to esConsumes AlignmentProducerAsAnalyzer and MuonMillepedeTrackRefitter modules #34542

hyunyong · 2021-07-18T22:03:31Z

PR description:

Part of #31061.

Migrate to esConsumes AlignmentProducerAsAnalyzer and MuonMillepedeTrackRefitter modules

PR validation:

#33583 has validtated.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport is needed.

cmsbuild · 2021-07-18T22:11:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34542/24065

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/CommonAlignmentProducer/interface/AlignmentProducerBase.h modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120
- File Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

cmsbuild · 2021-07-18T22:12:10Z

A new Pull Request was created by @hyunyong for master.

It involves the following packages:

Alignment/CommonAlignmentProducer (alca)
Alignment/MuonAlignmentAlgorithms (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @abbiendi, @jhgoh, @tocheng, @tlampen, @mmusich, @trocino this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

tvami · 2021-07-18T22:19:27Z

@cmsbuild , please test

cmsbuild · 2021-07-19T01:26:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abe914/16965/summary.html
COMMIT: 8b059e9
CMSSW: CMSSW_12_0_X_2021-07-18-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34542/16965/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abe914/16965/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2786302
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2786273
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

tvami · 2021-07-19T11:45:38Z

Hi @hyunyong, can you please deal with the static analyzer error, too? You seem to be using a legacy module:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abe914/16965/llvm-analysis/legacy-mod-sa.txt

hyunyong · 2021-07-19T16:37:15Z

Hi @hyunyong, can you please deal with the static analyzer error, too? You seem to be using a legacy module:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abe914/16965/llvm-analysis/legacy-mod-sa.txt

Yes, I've changed that module.

tvami · 2021-07-19T16:39:46Z

Hi @hyunyong, can you please deal with the static analyzer error, too? You seem to be using a legacy module:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abe914/16965/llvm-analysis/legacy-mod-sa.txt

Yes, I've changed that module.

Thanks, I'll trigger tests soon, but right now the IB seems to have problems.

cmsbuild · 2021-07-19T16:40:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34542/24081

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/CommonAlignmentProducer/interface/AlignmentProducerBase.h modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120
- File Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

cmsbuild · 2021-07-19T16:40:37Z

Pull request #34542 was updated. @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please check and sign again.

tvami · 2021-07-23T17:48:51Z

@cmsbuild , please test

cmsbuild · 2021-07-23T20:58:30Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abe914/17154/summary.html
COMMIT: 4f0b143
CMSSW: CMSSW_12_0_X_2021-07-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34542/17154/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 18
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998523
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

tvami · 2021-07-26T16:37:34Z

+alca

tvami · 2021-07-26T16:38:48Z

We don't expect any other changes with this PR, right?

srimanob · 2021-07-26T16:53:19Z

+Upgrade

cvuosalo · 2021-07-26T19:10:14Z

+1

tvami · 2021-07-26T19:28:22Z

@cms-sw/core-l2 I think there is a single file that made the PR require a signature from you, can you please review and sign? thanks!

makortel · 2021-07-26T19:32:16Z

+core

I think there is a single file that made the PR require a signature from you, can you please review and sign? thanks!

Missed that, thanks for pinging.

cmsbuild · 2021-07-26T19:32:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-07-26T20:55:35Z

+1

makortel · 2021-07-28T01:49:49Z

(sorry for the noise if these are already being worked on)

Just to note that there are further calls to helper functions that call the deprecated EventSetupRecord::get() from AlignmentProducerAsAnalyzer as shown here. Summary of the call stacks

AlignmentProducerAsAnalyzer::beginRun(); AlignmentProducerBase::beginRunImpl(); IntegratedCalibrationBase::beginRun() virtual; SiPixelLorentzAngleCalibration::beginRun();

AlignmentProducerAsAnalyzer::accumulate(); AlignmentProducerBase::processEvent(); AlignmentAlgorithmBase::run() virtual; MillePedeAlignmentAlgorithm::run(); TrajectoryFactoryBase::trajectories() const virtual; BzeroReferenceTrajectoryFactory::trajectories() const;
AlignmentProducerAsAnalyzer::accumulate(); AlignmentProducerBase::processEvent(); AlignmentAlgorithmBase::run() virtual; MillePedeAlignmentAlgorithm::run(); TrajectoryFactoryBase::trajectories() const virtual; DualBzeroTrajectoryFactory::trajectories() const;
AlignmentProducerAsAnalyzer::accumulate(); AlignmentProducerBase::processEvent(); AlignmentAlgorithmBase::run() virtual; MillePedeAlignmentAlgorithm::run(); TrajectoryFactoryBase::trajectories() const virtual; DualTrajectoryFactory::trajectories() const;
AlignmentProducerAsAnalyzer::accumulate(); AlignmentProducerBase::processEvent(); AlignmentAlgorithmBase::run() virtual; MillePedeAlignmentAlgorithm::run(); TrajectoryFactoryBase::trajectories() const virtual; ReferenceTrajectoryFactory::trajectories() const;
AlignmentProducerAsAnalyzer::accumulate(); AlignmentProducerBase::processEvent(); AlignmentAlgorithmBase::run() virtual; MillePedeAlignmentAlgorithm::run(); TrajectoryFactoryBase::trajectories() const virtual; TwoBodyDecayTrajectoryFactory::trajectories() const;

AlignmentProducerAsAnalyzer::accumulate(); AlignmentProducerBase::processEvent(); AlignmentAlgorithmBase::run() virtual; MuonAlignmentFromReference::run(); MuonResidualsFromTrack::MuonResidualsFromTrack();

The report from CMSSW_12_0_X_2021-07-26-2300 shows also

AlignmentProducerAsAnalyzer::accumulate(); AlignmentProducerBase::processEvent(); AlignmentAlgorithmBase::run() virtual; MillePedeAlignmentAlgorithm::run(); TrajectoryFactoryBase::trajectories() const virtual; TwoBodyDecayTrajectoryFactory::trajectories() const; reco::TransientTrack::setES();

that was addressed in #34584, but we don't have static analyzer reports for the CMSSW_12_0_X_2021-07-27-2300 IB yet.

1st commit

8b059e9

cmsbuild added this to the CMSSW_12_0_X milestone Jul 18, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Jul 18, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 18, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 18, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 19, 2021

cmsbuild mentioned this pull request Jul 19, 2021

Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120

Merged

use edm::stream::EDProducer

5751e21

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Jul 19, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 19, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 23, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 23, 2021

cmsbuild added alca-approved and removed alca-pending labels Jul 26, 2021

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 26, 2021

cmsbuild added geometry-approved and removed geometry-pending labels Jul 26, 2021

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Jul 26, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 26, 2021

cmsbuild merged commit 4bbdac2 into cms-sw:master Jul 26, 2021

qliphy mentioned this pull request Jul 27, 2021

Unit failure: test_PixelBaryCentreTool had ERRORS #34648

Closed

cmsbuild mentioned this pull request Jul 27, 2021

Re-enable suppression of CSC digis without matching pretriggers and triggers #34435

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to esConsumes AlignmentProducerAsAnalyzer and MuonMillepedeTrackRefitter modules #34542

Migrate to esConsumes AlignmentProducerAsAnalyzer and MuonMillepedeTrackRefitter modules #34542

hyunyong commented Jul 18, 2021

cmsbuild commented Jul 18, 2021

cmsbuild commented Jul 18, 2021

tvami commented Jul 18, 2021

cmsbuild commented Jul 19, 2021

tvami commented Jul 19, 2021

hyunyong commented Jul 19, 2021

tvami commented Jul 19, 2021

cmsbuild commented Jul 19, 2021

cmsbuild commented Jul 19, 2021

tvami commented Jul 23, 2021

cmsbuild commented Jul 23, 2021

tvami commented Jul 26, 2021

tvami commented Jul 26, 2021

srimanob commented Jul 26, 2021

cvuosalo commented Jul 26, 2021

tvami commented Jul 26, 2021

makortel commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

perrotta commented Jul 26, 2021

makortel commented Jul 28, 2021

Migrate to esConsumes AlignmentProducerAsAnalyzer and MuonMillepedeTrackRefitter modules #34542

Migrate to esConsumes AlignmentProducerAsAnalyzer and MuonMillepedeTrackRefitter modules #34542

Conversation

hyunyong commented Jul 18, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 18, 2021

cmsbuild commented Jul 18, 2021

tvami commented Jul 18, 2021

cmsbuild commented Jul 19, 2021

Comparison Summary

tvami commented Jul 19, 2021

hyunyong commented Jul 19, 2021

tvami commented Jul 19, 2021

cmsbuild commented Jul 19, 2021

cmsbuild commented Jul 19, 2021

tvami commented Jul 23, 2021

cmsbuild commented Jul 23, 2021

Comparison Summary

tvami commented Jul 26, 2021

tvami commented Jul 26, 2021

srimanob commented Jul 26, 2021

cvuosalo commented Jul 26, 2021

tvami commented Jul 26, 2021

makortel commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

perrotta commented Jul 26, 2021

makortel commented Jul 28, 2021