Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run3-hcx303 Add a few cfi's to help processing with DDD or DD4Hep #34569

Merged
merged 2 commits into from Jul 25, 2021
Merged

Run3-hcx303 Add a few cfi's to help processing with DDD or DD4Hep #34569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdf5ca0
Add a few cfi's to help processing with DDD or DD4Hep
Jul 20, 2021
4a7b2b5
Correction
Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Configuration/Geometry/python/GeometryDDDSimDB_cff.py
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import *
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometryDB_cfi import *
from Geometry.EcalCommonData.ecalSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalSimulationParameters_cfi import *
from Geometry.HcalCommonData.hcalSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
from Geometry.HcalCommonData.hcalSimulationConstants_cfi import *
from Geometry.HcalCommonData.caloSimulationParameters_cff import *
Expand Down
2 changes: 1 addition & 1 deletion Configuration/Geometry/python/GeometrySLHCSimDB_cff.py
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@
from GeometryReaders.XMLIdealGeometryESSource.cmsGeometryDB_cff import *
from Geometry.TrackerNumberingBuilder.trackerNumbering2026GeometryDB_cfi import *
from Geometry.EcalCommonData.ecalSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalSimulationParameters_cfi import *
from Geometry.HcalCommonData.hcalSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
from Geometry.HcalCommonData.hcalSimulationConstants_cfi import *
from Geometry.HcalCommonData.caloSimulationParameters_cff import *
Expand Down
3 changes: 1 addition & 2 deletions Geometry/HcalCommonData/python/hcalDDConstants_cff.py
View file
Open in desktop
Expand Up @@ -2,7 +2,6 @@

from Geometry.HcalCommonData.hcalParameters_cff import *
from Geometry.HcalCommonData.hcalSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
from Geometry.HcalCommonData.hcalSimulationConstants_cfi import *
from Geometry.HcalCommonData.hcalDDDRecConstants_cfi import *
from Geometry.HcalCommonData.caloSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalDBConstants_cff import *
2 changes: 1 addition & 1 deletion Geometry/HcalCommonData/python/hcalDDDSimConstants_cff.py
View file
Open in desktop
Expand Up @@ -2,6 +2,6 @@

from Geometry.HcalCommonData.hcalParameters_cff import *
from Geometry.HcalCommonData.hcalSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
from Geometry.HcalCommonData.hcalSimulationConstants_cfi import *
from Geometry.HcalCommonData.caloSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the order of the cfi's important?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it is not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, unless my eyes are failing me, there is no actual change to this file, and it should be removed from the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the conclusion on this question? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the ordering to be similar in all cff files. That is why it is changed here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from my side. This is up to @cvuosalo.

Thanks.

6 changes: 6 additions & 0 deletions Geometry/HcalCommonData/python/hcalDDFromDBConstants_cff.py
View file
Open in desktop
@@ -0,0 +1,6 @@
import FWCore.ParameterSet.Config as cms

from Geometry.HcalCommonData.hcalSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalSimulationConstants_cfi import *
from Geometry.HcalCommonData.caloSimulationParameters_cff import *
from Geometry.HcalCommonData.hcalDBConstants_cff import *