New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Track-gen matching passing through TrackingParticle (11_2_X) #34574
[Backport] Track-gen matching passing through TrackingParticle (11_2_X) #34574
Conversation
…d on their association to a gen particle
…ation is missing in AOD
…ection is missing in the associator
…s to remove when customizing cmsDriver to run on data
A new Pull Request was created by @elusian for CMSSW_11_2_X. It involves the following packages:
@perrotta, @civanch, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @silviodonato, @srimanob, @mdhildreth, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
backport of #33774 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you comment if this PR was tested in a bParking workflow in 11_2_X (1304.182)? Thanks!
|
||
template <typename T> | ||
std::vector<edm::DetSet<T>> pruneByTpAssoc(const edm::DetSetVector<T>& simLinkColl, | ||
const std::set<std::pair<uint32_t, EncodedEventId>>& selectedIds) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind why std::set is used here, while std::unordered_set in master?
https://github.com/cms-sw/cmssw/blob/master/SimTracker/TrackAssociation/plugins/DigiSimLinkPruner.cc#L45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ability to use std::unordered_set comes from #33462 which added the UniqueSimTrackId type and its hasher that enables std::unordered_set. It is not available on 11_2_X as far as I know. I had to do the same modification when backporting to 10_6_X.
SimTracker/TrackerHitAssociation/plugins/ClusterTPAssociationProducer.cc for example shows the same difference between 11_2_X and master
Yes, this was tested on 1304.182 |
+reconstruction
|
+1 |
+Upgrade |
@cms-sw/pdmv-l2 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will be automatically merged. |
This was merged a while ago, but is not in a release, as 11_2_X is closed. @elusian can you confirm that this is fine, or is something else required here? |
This backport was for a Hackaton about GNN for tracking that concluded today. I believe the code was manually imported by the participants even if it was not in the release. No need to do anything else. |
PR description:
This PR adds a way to match
generalTracks
(in AOD) andpackedPFCandidates
andlostTracks
(in miniAOD) to a subset ofgenParticles
, using association by hit onTrackingParticles
.The association is performed on step3 and just replicated in the miniAOD.
Since the track association by hit needs both
TrackingParticles
andSimLink
for pixel and strips and theSimLink
collections are not available in RAWSIM, two plugins are created to be run in step2 to add two pruned collections and avoid adding the all theSimLink
, which have a non negligible size.The changes contained are:
TrackingParticles
in step2 based on their association to specificGenParticles
. The genParticle selection is taken from theGenParticlePruner
class and can be configured.SimLink
collections based on theSimTrack
association to aTrackingParticle
PackedCandidates
andGenParticles
based on an existing association between tracks andGenParticles
No plugin is needed for association between tracks and
GenParticles
throughTrackingParticle
as it is already present in CMSSW (MCTrackMatcher
).PR validation:
On a B+->Psi2SK sample (one of the possible targets for this PR) we registered this increases in size, timing and memory
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #33774 and #34113 for an Hackaton for GNN tracking