Run3-alca190 Modify the AlCaRecoProducer for HBHEMuon

[bsunanda]

PR description:

Modify the AlCaRecoProducer for HBHEMuon

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

May need back porting to 12_0

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34709/24343

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34709/24343/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34709/24343/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34709/24344

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Calibration/HcalAlCaRecoProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6cfee7/17373/summary.html
COMMIT: a8db517
CMSSW: CMSSW_12_1_X_2021-07-30-0900/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34709/17373/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998529
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[yuanchao]

+1

• matrix tests and unit tests passed
• static build warnings are not part of the PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@bsunanda , since you added the default configuration via fillDescriptions (good!), please now remove the file with the explicit config with the same name Calibration/HcalAlCaRecoProducers/python/alcaHBHEMuonFilter_cfi.py

And then, in Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalHBHEMuonFilter_cff.py the line

from Calibration.HcalAlCaRecoProducers.alcaHBHEMuonFilter_cfi import *

should be changed as

from Calibration.HcalAlCaRecoProducers.AlcaHBHEMuonFilter_cfi import *

[bsunanda]

@perrotta There is no file named Calibration/HcalAlCaRecoProducers/python/alcaHBHEMuonFilter_cfi.py
in the PR - it was removed. Also the file created is named AlcaHBHEMuonFilter_cfi.py and that is why the cff file was modified.

[perrotta]

@perrotta There is no file named Calibration/HcalAlCaRecoProducers/python/alcaHBHEMuonFilter_cfi.py
in the PR - it was removed. Also the file created is named AlcaHBHEMuonFilter_cfi.py and that is why the cff file was modified.

Ok, great: you already did it, and I did not notice at first...
Everything is fine, then. Thank you Sunanda

[perrotta]

+1