Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects (CCLUT-17) #34779

dildick · 2021-08-04T16:47:23Z

PR description:

Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects. This should prevent cmsRun from spending too much time loading lookup tables for the pattern finding logic. This PR requires cms-data/L1Trigger-CSCTriggerPrimitives#11

In response to #34633

@Dr15Jones @makortel Supersedes #34693.

The CSC trigger is being upgraded for Phase-2 displaced muon triggering with (1) CCLUT that provides a more precise position and incident angle of the L1 CSC stub, and (2) GEM-CSC integrated local trigger to recover L1 CSC stub efficiency, improve ME1/1 and ME2/1 bending angle, and reduce muon trigger rate. The algorithms rely on lookup tables which are loaded into the FPGAs in the peripheral crates.
Existing lookup tables, which are in text files in cms-data/L1Trigger-CSCTriggerPrimitives, are loaded through a new reader called CSCL1TPLookupTableEP which is an ESProducer.
CSCL1TPLookupTableEP produces 3 types of ES data: (a) CSCL1TPLookupTableCCLUT, (b) CSCL1TPLookupTableME11ILT, and (c)CSCL1TPLookupTableME21ILT. (a) is for upgrade (1). (b) and (c) are for upgrade (2).
(b) and (c) convert GEM system coordinates to CSC coordinates in order to match GEM clusters with L1 CSC stubs. They also contain utilities to allow for purer GEM-CSC matches (i.e. more likely to be the correct match in MC truth) based on position and slope from CSCL1TPLookupTableCCLUT.
The ES data objects are requested in the CSC trigger plugin and propagate to specific components that actually use them. For instance, CSCL1TPLookupTableCCLUT follows CSCTriggerPrimitivesProducer->CSCTriggerPrimitivesBuilder->CSCMotherBoard->CSCCathodeLCTProcessor->ComparatorCodeLUT.

Proposal was presented at https://indico.cern.ch/event/1065089/contributions/4478403/attachments/2292436/3897925/GEM_CSC_Trigger_AlcaDB_20210808.pdf

PR validation:

Tested the code so far on /RelValSingleMuPt10/CMSSW_11_3_0-113X_mcRun4_realistic_v7_2026D76noPU-v1/GEN-SIM-DIGI-RAW. Efficiency plots for ME1/1 and ME2/1 are the same as in #34582.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N.A.

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@tahuang1991

dildick · 2021-08-04T16:53:30Z

FYI @rathjd

dildick · 2021-08-04T16:54:49Z

I see the exact same 2 validation plots as in #34582. So the LUTs are looked and used alright.

cmsbuild · 2021-08-04T16:55:18Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34779/24446

This PR adds an extra 476KB to repository
Found files with invalid states:
- CalibMuon/CSCCalibration/src/CSCL1TPLookupTableEP.cc:
  - Added: 16987a2
  - Modified: dc439e0, c098b7c
  - Deleted: 988460a
- CalibMuon/CSCCalibration/python/CSCL1TPLookupTable_cff.py:
  - Added: 16987a2
  - Deleted: cdde3ba
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCTriggerPrimitives/python/cscTriggerPrimitiveDigis_cfi.py modified in PR(s): Temporarily disable the GEM-CSC triggers #34693

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34779/24446/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34779/24446/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

dildick · 2021-08-04T17:05:07Z

Originally I had the luts pass by reference in CalibMuon/CSCCalibration/plugins/CSCL1TPLookupTableEP.cc. @Dr15Jones suggest to change to pass by value + std::move. code-checks is suggesting to remove the std::move, which would make it pass by value only. Not sure which recommendation to follow.

Dr15Jones · 2021-08-04T17:53:43Z

CalibMuon/CSCCalibration/plugins/CSCL1TPLookupTableEP.cc

+      pset_.getParameter<std::vector<std::string>>("esDiffToSlopeME1bFiles");
+
+  // read the text files and extract the data
+  const auto& GEM_pad_CSC_hs_ME1a_even_ = load(padToHsME1aFiles_[0]);


Change the type from const auto& to just auto. This will allow the std::move to work.

tvami · 2021-08-04T18:15:13Z

Hi @dildick while we are still at the code checks part, can you please squash some of the commits (bugfix, change name, several code checks)? Thanks!

cmsbuild · 2021-08-04T18:19:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34779/24450

This PR adds an extra 476KB to repository
Found files with invalid states:
- CalibMuon/CSCCalibration/src/CSCL1TPLookupTableEP.cc:
  - Added: 16987a2
  - Modified: dc439e0, c098b7c
  - Deleted: 988460a
- CalibMuon/CSCCalibration/python/CSCL1TPLookupTable_cff.py:
  - Added: 16987a2
  - Deleted: cdde3ba
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCTriggerPrimitives/python/cscTriggerPrimitiveDigis_cfi.py modified in PR(s): Temporarily disable the GEM-CSC triggers #34693

cmsbuild · 2021-08-04T18:22:45Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

CalibMuon/CSCCalibration (alca)
CondFormats/CSCObjects (db, alca)
CondFormats/DataRecord (db, alca)
DQM/L1TMonitor (dqm)
L1Trigger/CSCTriggerPrimitives (l1)
L1Trigger/Configuration (l1)
L1Trigger/L1TMuon (l1)

@malbouis, @andrius-k, @yuanchao, @kmaeshima, @ErnestaP, @ahmad3213, @rvenditti, @cmsbuild, @rekovic, @jfernan2, @tlampen, @ggovi, @pohsun, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @tocheng, @valuev, @ptcox, @thomreis, @dinyar, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

dildick · 2021-08-04T18:25:35Z

@tvami Done. It can all go into a single commit.

tvami · 2021-08-04T18:29:14Z

@dildick great thanks! Another thing that when a new record is introduced, we usually like if there is a presentation about it at the AlCaDB meeting. Would you be available to present at the next meeting (Monday, 16:00)?

cmsbuild · 2021-08-04T18:29:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34779/24453

This PR adds an extra 128KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCTriggerPrimitives/python/cscTriggerPrimitiveDigis_cfi.py modified in PR(s): Temporarily disable the GEM-CSC triggers #34693

qliphy · 2021-08-31T15:41:47Z

please test
(just to re-test to make sure..)

dildick · 2021-08-31T20:26:47Z

@qliphy Are the tests stuck?

tvami · 2021-08-31T20:39:21Z

@cmsbuild , ping

tvami · 2021-08-31T21:09:26Z

@cmsbuild , please test

dildick · 2021-09-01T02:22:09Z

ping @tvami. Is the bot stuck again on the same test?

perrotta · 2021-09-01T06:39:58Z

@smuzaffar : tests look stuck ("Not yet started" since several hours) in several PR. Is there anyfhing that can be done to start them?

smuzaffar · 2021-09-01T08:56:14Z

please test

cmsbuild · 2021-09-01T22:56:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-297c50/18195/summary.html
COMMIT: 7787a9b
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34779/18195/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000404
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3000376
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-09-02T07:36:10Z

+1

dildick · 2021-09-02T16:00:30Z

@qliphy Can this PR be signed off? Thanks!

qliphy · 2021-09-03T00:57:00Z

+1

cmsbuild added this to the CMSSW_12_1_X milestone Aug 4, 2021

cmsbuild added alca-pending code-checks-pending db-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Aug 4, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 4, 2021

Dr15Jones reviewed Aug 4, 2021

View reviewed changes

dildick mentioned this pull request Aug 4, 2021

Temporarily disable the GEM-CSC triggers #34693

Closed

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 4, 2021

Put CSC and GEM-CSC local trigger lookup tables in ES objects

7787a9b

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 4, 2021

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 4, 2021

cmsbuild added fully-signed l1-approved and removed pending-signatures labels Aug 31, 2021

cmsbuild added tests-started and removed tests-approved labels Aug 31, 2021

cmsbuild mentioned this pull request Aug 31, 2021

Address undefined behavior as reported by UBSAN in CSC and GEM L1T producers #35098

Closed

cmsbuild mentioned this pull request Sep 1, 2021

Extend L1T CSC DQM with option for ME234/2 chambers and ME2/1 chamber at B904 #35100

Merged

cmsbuild mentioned this pull request Sep 1, 2021

new package L1Trigger/L1TMuonOverlapPhase1 (new version of the L1 Trigger Overlap Muon Track Finder (OMTF) emulator) #35111

Merged

cmsbuild added tests-approved and removed tests-started labels Sep 1, 2021

qliphy mentioned this pull request Sep 3, 2021

Add dummy GEM-CSC bending angle LUTs cms-data/L1Trigger-CSCTriggerPrimitives#11

Merged

cmsbuild added orp-approved and removed orp-pending labels Sep 3, 2021

cmsbuild merged commit 7912bbc into cms-sw:master Sep 3, 2021

dildick deleted the from-CMSSW_12_0_X_2021-07-29-2300-CSCL1TPLookupTable-v3 branch September 3, 2021 01:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects (CCLUT-17) #34779

Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects (CCLUT-17) #34779

dildick commented Aug 4, 2021 •

edited

Loading

dildick commented Aug 4, 2021

dildick commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

dildick commented Aug 4, 2021

Dr15Jones Aug 4, 2021

dildick Aug 4, 2021

tvami commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

dildick commented Aug 4, 2021

tvami commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

qliphy commented Aug 31, 2021

dildick commented Aug 31, 2021

tvami commented Aug 31, 2021

tvami commented Aug 31, 2021

dildick commented Sep 1, 2021

perrotta commented Sep 1, 2021

smuzaffar commented Sep 1, 2021

cmsbuild commented Sep 1, 2021

jfernan2 commented Sep 2, 2021

dildick commented Sep 2, 2021

qliphy commented Sep 3, 2021

Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects (CCLUT-17) #34779

Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects (CCLUT-17) #34779

Conversation

dildick commented Aug 4, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

dildick commented Aug 4, 2021

dildick commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

dildick commented Aug 4, 2021

Dr15Jones Aug 4, 2021

Choose a reason for hiding this comment

dildick Aug 4, 2021

Choose a reason for hiding this comment

tvami commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

dildick commented Aug 4, 2021

tvami commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

qliphy commented Aug 31, 2021

dildick commented Aug 31, 2021

tvami commented Aug 31, 2021

tvami commented Aug 31, 2021

dildick commented Sep 1, 2021

perrotta commented Sep 1, 2021

smuzaffar commented Sep 1, 2021

cmsbuild commented Sep 1, 2021

Comparison Summary

jfernan2 commented Sep 2, 2021

dildick commented Sep 2, 2021

qliphy commented Sep 3, 2021

dildick commented Aug 4, 2021 •

edited

Loading