HLT customisation for Patatrack pixel tracks and GPU offload #34956
Conversation
Add a customisation script for the HLT: - enable the Patatrack pixel track reconstruction, with quadruplets or triplets, running on CPU or GPU - optionally, add the possibility to offload the ECAL unpacking and local reconstruction to run on GPU - optionally, add the possibility to offload the HCAL local reconstruction to run on GPU Co-authored-by: Andrea Massironi <massironi.andrea@gmail.com>
|
@cmsbuild, please test To make the bot happy, even if the new customisation is not used anywhere. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34956/24776
|
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a99d23/17896/summary.html Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
+1
|
|
(Leaving a comment for @fwyzard, even though the PR is closed) If using an HLT config with only a subset of triggers, it can happen that some of the customisations are silently skipped. I noticed this when testing a config with (only) the path I guess one option is to just improve a bit the safeguards at the beginning of the functions (maybe just the ECAL one). I was wondering if it would be okay to remove the safeguards altogether (and then, if no path uses the customised sequences/tasks, those will be ignored in any case?). |
|
@missirol thanks for the comment. We cannot run the customisation unconditionally, as they would fail if the configuration is missing the modules it references, e.g. process.hltEcalDigisLegacy = process.hltEcalDigis.clone()will fail if It may be enough to change -if not 'HLTDoFullUnpackingEgammaEcalSequence' in process.__dict__:
+if not any(seq in process.__dict__ for seq in ['HLTDoFullUnpackingEgammaEcalMFSequence', 'HLTDoFullUnpackingEgammaEcalWithoutPreshowerSequence', 'HLTDoFullUnpackingEgammaEcalSequence'):Could you give it a try ? |
|
Thanks, @fwyzard . Yep, will try. |
PR description:
Add a customisation script for the HLT:
The new customisation is not used by any workflows.
PR validation:
Validated in CMSSW_12_1_0_pre1 with
cmsDriver.py reHLT \ --processName reHLT \ -s HLT:@relval2021 \ --conditions 120X_mcRun3_2021_realistic_v4 \ --datatier GEN-SIM-DIGI-RAW \ -n 10 \ --eventcontent FEVTDEBUGHLT \ --geometry DB:Extended \ --era Run3 \ --customise=HLTrigger/Configuration/customizeHLTforPatatrack.customizeHLTforPatatrackTriplets \ --filein /store/relval/CMSSW_12_0_0_pre6/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_120X_mcRun3_2021_realistic_v4_JIRA_129-v1/00000/79c06ed5-929b-4a57-a4f2-1ae90e6b38c5.rootresulting in
Tested successfully both with and without a GPU.
The physics validation and the GPU vs CPU comparison will follow after the customisation has been merged.