Fixing some edge cases in HLT-Patatrack customisations

[missirol]

PR description:

This PR is an attempt to make the HLT-Patatrack customisations introduced in #34956 a bit more robust (mostly to handle some edge cases, e.g. HLT configs with only a limited number of paths; see this comment for an example).

Suggestions on the implementation are welcomed.

Attn: @fwyzard

PR validation:

With the PR, the customisations are applied as intended in the following 3 tests (without PR, the first 2 tests wouldn't work correctly).

#!/bin/bash -ex

scram project CMSSW CMSSW_12_1_X_2021-08-23-2300
cd CMSSW_12_1_X_2021-08-23-2300/src
eval `scram runtime -sh`
git cms-merge-topic cmssw:34992
scram build

hltTest(){

  hltGetConfiguration /dev/CMSSW_12_0_0/GRun/V5 \
  --offline --mc --unprescale --process TEST \
  --input /store/relval/CMSSW_12_0_0_pre6/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_120X_mcRun3_2021_realistic_v4-v1/00000/20a08d38-8b7f-4ce4-b24b-edc023ddd078.root \
  --output none \
  --era Run3 --globaltag 121X_mcRun3_2021_realistic_v1 \
  --customise HLTrigger/Configuration/customizeHLTforPatatrack.customizeHLTforPatatrackTriplets \
  --max-events 10 \
  "${@:2}" > "$1"_cfg.py

  edmConfigDump "$1"_cfg.py > "$1".py

  python3 "$1".py
  cmsRun "$1".py
}

hltTest hltPartial1 --paths HLTriggerFirstPath,MC_PFMET_v17,HLTriggerFinalPath
hltTest hltPartial2 --paths HLTriggerFirstPath,HLT_UncorrectedJetE30_NoBPTX_v6,HLTriggerFinalPath
hltTest hltFull

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34992/24844

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

do we need/want to support the case where the configuration has HLTRecoPixelTracksSequence but not HLTRecopixelvertexingSequence ?

[missirol]

I couldn't find a use case like this in the GRun menu, but supporting this seems easy enough.

Tentatively added in e397a38176c.

Checked that e397a38176c works as intended, by testing a config with

+process.MC_PixelTracksOnly_v0 = cms.Path(process.HLTRecoPixelTracksSequence)
+process.setSchedule_(cms.Schedule(process.MC_PixelTracksOnly_v0))
+process.prune()

#User-defined customization functions
from HLTrigger.Configuration.customizeHLTforPatatrack import customizeHLTforPatatrackTriplets
process = customizeHLTforPatatrackTriplets(process)

[fwyzard]

Nice, thanks @missirol .

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34992/24849

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #34992 was updated. @Martin-Grunewald can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-097e4d/17998/summary.html
COMMIT: e397a38
CMSSW: CMSSW_12_1_X_2021-08-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34992/17998/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000324
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1