initialize TrackstersProducer::iterIndex_ to 0

[slava77]

#34605 is an example of using iternames which can not be decoded by RecoHGCal/TICL/plugins/TrackstersProducer.cc. E.g. ticlTrackstersHFNoseEM uses EMn.
This means that the uninitialized TrackstersProducer::iterIndex_ is used to set the tracksters iteration. This leads to non-repeatable changes in this variable in the data outputs.

This PR sets the value to a somewhat inconvenient default of 0 to restore repeatable results in reco comparisons.

Some better solution may be needed; to be done by some HGCAL experts
@cms-sw/hgcal-dpg-l2

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34962/24792

ERROR: Build errors found during clang-tidy run.

RecoHGCal/TICL/plugins/TrackstersProducer.cc:58:48: error: cannot initialize a member subobject of type 'ticl::Trackster::IterationIndex' with an rvalue of type 'int' [clang-diagnostic-error]
  ticl::Trackster::IterationIndex iterIndex_ = 0;
                                               ^
Suppressed 2389 warnings (2385 in non-user code, 3 NOLINT, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34962/24793

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

• RecoHGCal/TICL (upgrade, reconstruction)

@kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @ebrondol, @clelange this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b1fca/17921/summary.html
COMMIT: bf54420
CMSSW: CMSSW_12_1_X_2021-08-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34962/17921/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @abhih1 Correct labels for a Trigger plot in ECAL DQM #34953
• @lecriste [HGCAL] Improve validation scripts #34954
• @fwyzard Fix uploading the EventSetup conditions to multiple CUDA devices #34948

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b1fca/17921/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b1fca/17921/git-merge-result

RelVals-INPUT

• 13034.9913034.99_TTbar_14TeV+2024PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano/step2_TTbar_14TeV+2024PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimINPUT+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano.log
• 23434.992123434.9921_TTbar_14TeV+2026D49PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log
• 250202.181250202.181_TTbar_13UP18+TTbar_13UP18INPUT+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18INPUT+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2939908
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939874
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

Failed Tests: RelVals-INPUT

all 3 failed in OscarMTProducer::OscarMTProducer, which seems unrelated.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b1fca/17935/summary.html
COMMIT: bf54420
CMSSW: CMSSW_12_1_X_2021-08-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34962/17935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34962 bf54420

• jenkins tests pass and comparisons with the baseline show differences in the phase-2 D60 HFNose test workflow 28234.0 in ticlTrackstersHFNose* products ticlIteration values, which change from somewhat random ints to 0.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• It allows repeatibility in ticlTrackstersHFNose*
• I agree that a better initialization value should be defined by @cms-sw/hgcal-dpg-l2: github issue [HGCAL/TICL] define/assign ticlIteration for HFNose and default-constructed tracksters #34971 was opened by Slava exactly on that purpose