Run3-hcx310 Put back HcalDigiProducer.cc in SimCalorimetry/HcalSimProducers/src

[bsunanda]

PR description:

Put back HcalDigiProducer.cc in SimCalorimetry/HcalSimProducers/src to avoid the broken IB as it needs to be linkable with the mixing module (Chris Jones)

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Fixes the broken IB due to #34940

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34972/24812

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• SimCalorimetry/HcalSimProducers (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@mariadalfonso, @abdoulline, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e25666/17943/summary.html
COMMIT: fea5cc2
CMSSW: CMSSW_12_1_X_2021-08-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34972/17943/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Migrate PFTauPrimaryVertexProducerBase to esConsumes() #34935
• @makortel Migrate PFSimParticleProducer to esConsumes() #34938
• @bsunanda Run3-hcx308 Rearrange the files to remove .h files from SimCalorimetry/CastorSim/src #34939
• @makortel Migrate some modules in RecoTracker to esConsumes() #34934
• @Dr15Jones Simplify setting EDPutTokenT via call to produces #34926
• @makortel Migrate some modules in RecoHI to esConsumes() #34961
• @makortel Migrate some modules in RecoJets to esConsumes() #34959
• @slava77 initialize TrackstersProducer::iterIndex_ to 0 #34962
• @osschar [Fireworks/Geometry] Strip topolgy for sub-classes of StripTopology was not exported to RECO geometry. #34960
• @makortel Remove MuonToSimAssociatorBase, MuonToSimAssociatorByHits, and TrackAssociatorRecord as obsolete #34944
• @makortel Migrate some modules in RecoMET to esConsumes() #34943
• @bsunanda Run3-hcx309 Rearrange the files to remove .h files from SimCalorimetry/HcalSimProducers/src #34940

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e25666/17943/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e25666/17943/git-merge-result

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1303 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 3671
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2996640
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.703 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[qliphy]

urgent

[qliphy]

type bugfix

[perrotta]

This PR reverts the part of #34940 that prevents compiling SimGeneral/DataMixingModule (and therefore IBs cannot be built and tested). My suggestion is to merge it anyhow before the 1100 IB, unless there are serious objections, so that integrations and release tests can be restarted.

[perrotta]

+1

• It reverts the moving of one file (HcalDigiProducer.cc ) from src to plugin area in Run3-hcx309 Rearrange the files to remove .h files from SimCalorimetry/HcalSimProducers/src #34940, which prevents now building the IB
• Let have this merged before this morning 1100 IB

[perrotta]

merge