[HGCAL] Adding comments in HGCAL associators

[apsallid]

PR description:

This PR addresses the following issues:

1. It includes some comments in HGCAL associators to make some complicated objects easier to understand.
2. It removes the unused deprecated detIdInfoInMultiCluster struct.

PR validation:

Tested locally with workflow 34624.0. We expect no differences in any workflow.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport.

@rovere @felicepantaleo @lecriste @ebrondol

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35104/24993

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35104/24993/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35104/24993/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35104/25000

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @apsallid for master.

It involves the following packages:

• SimCalorimetry/HGCalAssociatorProducers (upgrade, simulation)

@cmsbuild, @AdrianoDee, @civanch, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[AdrianoDee]

test parameters:

• workflow=34624.0

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8ec3/18219/summary.html
COMMIT: 73dc6aa
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35104/18219/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

[srimanob]

Workflow 34624 is TTbar_13 TeV with D76. Testing with default short matrix 34634 (TTbar_14TeV) should be the same.

[srimanob]

test parameters:

[srimanob]

Please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8ec3/18237/summary.html
COMMIT: 73dc6aa
CMSSW: CMSSW_12_1_X_2021-09-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35104/18237/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 136.72413136.72413_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000376
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[srimanob]

The failure is not related to this PR,
see #35121

[srimanob]

Please test with #35121

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8ec3/18246/summary.html
COMMIT: 73dc6aa
CMSSW: CMSSW_12_1_X_2021-09-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35104/18246/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000382
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[AdrianoDee]

+upgrade

• code changes consistent with the PR description (adding comments + removing ‘detIdInfoInMultiCluster struct)
• no changes seen (in reco, DQM, TriggerResults, ...), as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1