New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prodlike workflows #36050
Fix prodlike workflows #36050
Conversation
Update master
update master
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36050/26511
|
A new Pull Request was created by @kskovpen for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
assign reconstruction |
please test |
-1 Failed Tests: RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d03ff/20364/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
Pull request #36050 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata can you please check and sign again. |
please test |
-1 Failed Tests: RelVals RelVals |
@kskovpen this PR is still not consistent with my branch. e.g. having a Reco step that doesn't have Reco in the name ("RecNan") can cause problems for custom workflows that check for this. Please use the consistent implementation that I provided instead of making haphazard changes. |
some changes from master...kpedro88:Phase2-WF75v2 are still missing here. what is the problem? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36050/26723
|
Pull request #36050 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata can you please check and sign again. |
superseded by #36167, please close this. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36050/26725
|
Pull request #36050 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata can you please check and sign again. |
PR description:
Hopefully, fixes #35966
PR validation:
Tested on standard and prodlike wfs
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport