Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL esConsumes migration various packages #35149

Merged

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Sep 3, 2021

PR description:

This PR migrates ECAL related code in the various reco and db packages to esConsumes (#31061). In addition getByLabel() calls were replaced by getByToken()and legacy module types were migrated to multithreaded module types.

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35149/25068

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2021

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

  • CondTools/Ecal (db)
  • RecoEcal/EgammaCoreTools (reconstruction)
  • RecoHI/HiEgammaAlgos (reconstruction)
  • RecoTBCalo/EcalSimpleTBAnalysis (reconstruction)
  • RecoTBCalo/EcalTBRecProducers (reconstruction)

@ggovi, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @thomreis, @rchatter, @jainshilpi, @afiqaize, @varuns23, @jazzitup, @lgray, @yenjie, @sobhatta, @kurtejung, @simonepigazzini, @yetkinyilmaz, @mmusich, @argiro, @mandrenguyen, @dgulhan, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Sep 3, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd61d5/18305/summary.html
COMMIT: 9a7dbd1
CMSSW: CMSSW_12_1_X_2021-09-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35149/18305/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000382
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@ggovi
Copy link
Contributor

ggovi commented Sep 7, 2021

+1

@jpata
Copy link
Contributor

jpata commented Sep 7, 2021

+reconstruction

  • for 9a7dbd1
  • technical, no reco differences observed/expected
  • the switch from legacy modules to edm::one/stream seems correct to me

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 8, 2021

+1

@cmsbuild cmsbuild merged commit 51c9398 into cms-sw:master Sep 8, 2021
@thomreis thomreis deleted the ecal-esconsumes-migration-leftbehinds branch September 8, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants