Fix signal in external generator [backport to 10_6] #35219
Conversation
This option avoids resetting the unix signal hanlder which was already set by the external application.
This tests failures for exceptions and unix signals which can occur in the constructor, begin lumi or event.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_10_6_X. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b854a/18464/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
backport of #35201 |
|
|
||
| process.source = cms.Source("EmptySource") | ||
|
|
||
| process.maxEvents = cms.untracked.PSet(input=cms.untracked.int32(10)) |
There was a problem hiding this comment.
Why not simply "10"? (just curious....)
There was a problem hiding this comment.
In newer releases one can do process.maxEvents.input = 10 because the cms.Process object internally knows that maxEvents is a untracked.PSet and knows what are the allowed parameters (and their types) with that PSet. Unfortunately, 10_6 doesn't have that change so one is required to explicitly use all the types.
|
+1 |
PR description:
back port of #35201
PR validation:
Code compiles and new unit test passes.