Remove throwing of test Exception in SherpaHadronizer

[Dr15Jones]

PR description:

• code was left over from testing possible failures

PR validation:

Actually ran a job using the SherpaHadronizer and it ran fine.

[Dr15Jones]

type bug

[Dr15Jones]

urgent

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35224/25178

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• GeneratorInterface/SherpaInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano, @thuer this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f2063/18477/summary.html
COMMIT: 5299229
CMSSW: CMSSW_12_1_X_2021-09-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35224/18477/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @therwig Susy gen fragment for trigger validation #35203
• @Dr15Jones Handle more generator problems in external generator #35201
• @cms-tsg-storm Update of HLT GTs for Run3 #35207
• @bsunanda Run3-hcx330 Make use of ESGetToken in DPGAnalysis/HcalTools #35186
• @Dr15Jones Fixed exceptional case handling in SherpaHadronizer #35204
• @Dr15Jones esConsumes for PhotonProducer/GsfPhotonProducer #35151

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f2063/18477/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f2063/18477/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• @GurpreetSinghChahal, this fixes an extra line with a test Throw leftover in Fixed exceptional case handling in SherpaHadronizer #35204. That line escaped both mine and your reviews. Let have this fix merged already in the next IB: I imagine you have nothing against it, just react if you have any comment

[perrotta]

merge

[Dr15Jones]

On a positive note, the failures in yesterday's IB from this oversite do show that my other fix to the cmsExternalGenerator code does work as the exception thrown in the external process does lead to a clean shutdown of cmsRun :).