Add new ECAL PF RecHit thresholds for 2021 Run 3 MC

[malbouis]

PR description:

This PR is to add a new ECAL tag, EcalPFRecHitThresholds_34sigma_TL235, to the 2021 Run-3 MC GTs as per request from the ECAL group (https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4462.html), aiming the Run 3 MC Campaign (in 120X).

The differences wrt the previous GTs are listed below.

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v1/121X_mcRun3_2021_realistic_v2

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v1/121X_mcRun3_2021cosmics_realistic_deco_v2

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v1/121X_mcRun3_2021_realistic_HI_v2

PR validation:

runTheMatrix.py -l 159.0,11634.0,7.23 --ibeos -j4

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR will be backported to 120X.

[malbouis]

test parameters:

workflows = 159.0,11634.0,7.23

[malbouis]

test parameters:

• workflows = 159.0,11634.0,7.23

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35233/25193

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @malbouis for master.

It involves the following packages:

• Configuration/AlCa (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[malbouis]

please test

[tvami]

urgent

• the backport of this is needed for the PF calibration

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-617f1e/18506/summary.html
COMMIT: 3a67ae8
CMSSW: CMSSW_12_1_X_2021-09-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35233/18506/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-617f1e/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

• No significant changes to the logs found
• Reco comparison results: 4532 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 1155
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999824
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 2 / 38 workflows

[tvami]

• DQMHistoTests: Total failures: 1155

• ECAL changes are expected.

• Are the changes (a big amount) in the b-tagging expected?
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-09-10-1100+617f1e/45373/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/Btag.html

• There are also a few changes in JetMET, ParticleFlow (I'd have expected more changes here...)
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-09-10-1100+617f1e/45373/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/

@bendavid @hatakeyamak @juska @kdlong @Pigazzini @rappoccio @kmaeshima

[tvami]

Let me also tag @cms-sw/ecal-dpg-l2 @fcouderc (please also add any other relevant people)

[hatakeyamak]

I went over observed changes quickly. Not surprising, there are quite a few changes in ECAL related reco quantities, so it's hard to digest all of them, but by looking at PF validation plots, I see that changes are specifically coming from PF photons [1], which we expect. This [2] shows PF photon candidate p distribution, and we see a big suppresion at low pt, which again we expect. So, the observed changes are certainly going in the direction we expect.

[1] https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-09-10-1100+617f1e/45373/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/ParticleFlow_PackedCandidates.html

[2] https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-09-10-1100+617f1e/45373/validateJR/all_OldVSNew_TTbar14TeV2021wf11634p0/all_OldVSNew_TTbar14TeV2021wf11634p0c_log10recoPFCandidates_particleFlow__RECO_obj_p72.png

[tvami]

• Are the changes (a big amount) in the b-tagging expected?
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-09-10-1100+617f1e/45373/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/Btag.html

Maybe the b-tagging conveners could take this? @johnalison @soureek

[hatakeyamak]

• Are the changes (a big amount) in the b-tagging expected?
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-09-10-1100+617f1e/45373/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/Btag.html

Maybe the b-tagging conveners could take this? @johnalison @soureek

We should certainly hear from b-tag experts, but just sharing what I gathered form a quick look. From what I see, many of failures comes from low entry plots where the original blue ones have just one or only handful entries, and in new/test red ones some of the entries disappear. Due to increased PF ECAL thresholds, such behaviors don't seem too surprising.

[tvami]

+alca

• The changes in the Jenkins tests are expected and understood
• b-tagging was contacted privately to explain the changes in those plots

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1