Protection against missing discriminators for offline taus in L1 DQM #35305

lathomas · 2021-09-16T14:25:39Z

PR description:

This (hopefully) is a short term bug fix of the issue described in #35304
In very rare cases, the anti electron discriminators seem to be missing for offline tau, leading to a crash in the L1 DQM code.
A protection is added to skip such offline taus.

PR validation:

Checked that the crash in #35304 is gone after this fix.

@tvami

tvami · 2021-09-16T14:30:01Z

type bug-fix

tvami · 2021-09-16T14:30:06Z

urgent

tvami · 2021-09-16T14:32:43Z

DQMOffline/L1Trigger/src/L1TTauOffline.cc

@@ -704,6 +704,19 @@ void L1TTauOffline::getProbeTaus(const edm::Event& iEvent,
      TLorentzVector mytau;
      mytau.SetPtEtaPhiE(tauIt->pt(), tauIt->eta(), tauIt->phi(), tauIt->energy());

+      if ((*antimu)[tauCandidate].workingPoints.empty()) {
+        LogWarning("This offline tau has no antimu discriminator, skipping");


@lathomas isnt the structure with the LogWarning something like
edm::LogWarning("category") << "message to be printed";

Yes I think this should be
edm::LogWarning("L1TTauOffline") << "This offline tau has no antimu discriminator, skipping";
Please do the same with the other ones too

Ah yes, will do.

Hi @lathomas please dont forget to push your fix :)

cmsbuild · 2021-09-16T14:35:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35305/25320

This PR adds an extra 20KB to repository

cmsbuild · 2021-09-16T14:35:53Z

A new Pull Request was created by @lathomas for master.

It involves the following packages:

DQMOffline/L1Trigger (dqm, l1)

@emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2021-09-16T16:03:35Z

@cmsbuild , please test

cmsbuild · 2021-09-16T19:10:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35305/25331

This PR adds an extra 20KB to repository

cmsbuild · 2021-09-16T19:10:58Z

Pull request #35305 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please check and sign again.

tvami · 2021-09-16T19:11:05Z

@cmsbuild , please test

lathomas · 2021-09-16T19:11:23Z

@tvami

cmsbuild · 2021-09-16T22:16:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccde59/18676/summary.html
COMMIT: d9cf860
CMSSW: CMSSW_12_1_X_2021-09-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35305/18676/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000833
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3000805
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

tvami · 2021-09-16T22:49:44Z

All looks good, @jfernan2 @rekovic please sign this as soon as possible, so that we can submit the backport and cut a new release for CRAFT, thanks!

jfernan2 · 2021-09-17T12:10:16Z

+1

tvami · 2021-09-17T13:31:12Z

Hi @perrotta @qliphy give the urgency and the simplicity of this PR, would you please consider to merge this without the L1 signature?

qliphy · 2021-09-17T14:32:05Z

+1

qliphy · 2021-09-17T14:32:13Z

merge

lathomas · 2021-09-17T14:54:45Z

@tvami I won't be able to take care of the backport(s). Can we identify someone else?

tvami · 2021-09-17T15:01:05Z

@tvami I won't be able to take care of the backport(s). Can we identify someone else?

I did it myself, please see #35322

Protection against missing discriminators for offline taus in L1 DQM

4cb5eeb

cmsbuild added this to the CMSSW_12_1_X milestone Sep 16, 2021

cmsbuild added code-checks-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Sep 16, 2021

cmsbuild added bug-fix tests-started urgent and removed tests-pending labels Sep 16, 2021

tvami reviewed Sep 16, 2021

View reviewed changes

cmsbuild added tests-pending and removed tests-started labels Sep 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 16, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 16, 2021

Fixing LogWarning message

d9cf860

cmsbuild added code-checks-pending tests-pending and removed tests-started code-checks-approved labels Sep 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 16, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 16, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 16, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Sep 17, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 17, 2021

cmsbuild merged commit 2927ff3 into cms-sw:master Sep 17, 2021

tvami mentioned this pull request Sep 17, 2021

[12_0_X] Protection against missing discriminators for offline taus in L1 DQM #35322

Merged

cmsbuild mentioned this pull request Sep 20, 2021

Update Geant4 to 10.7.2 cms-sw/cmsdist#7316

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Protection against missing discriminators for offline taus in L1 DQM #35305

Protection against missing discriminators for offline taus in L1 DQM #35305

lathomas commented Sep 16, 2021

tvami commented Sep 16, 2021

tvami commented Sep 16, 2021

tvami Sep 16, 2021 •

edited

tvami Sep 16, 2021

lathomas Sep 16, 2021

tvami Sep 16, 2021

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

tvami commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

tvami commented Sep 16, 2021

lathomas commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

tvami commented Sep 16, 2021

jfernan2 commented Sep 17, 2021

tvami commented Sep 17, 2021

qliphy commented Sep 17, 2021

qliphy commented Sep 17, 2021

lathomas commented Sep 17, 2021

tvami commented Sep 17, 2021

Protection against missing discriminators for offline taus in L1 DQM #35305

Protection against missing discriminators for offline taus in L1 DQM #35305

Conversation

lathomas commented Sep 16, 2021

PR description:

PR validation:

tvami commented Sep 16, 2021

tvami commented Sep 16, 2021

tvami Sep 16, 2021 • edited

Choose a reason for hiding this comment

tvami Sep 16, 2021

Choose a reason for hiding this comment

lathomas Sep 16, 2021

Choose a reason for hiding this comment

tvami Sep 16, 2021

Choose a reason for hiding this comment

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

tvami commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

tvami commented Sep 16, 2021

lathomas commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

Comparison Summary

tvami commented Sep 16, 2021

jfernan2 commented Sep 17, 2021

tvami commented Sep 17, 2021

qliphy commented Sep 17, 2021

qliphy commented Sep 17, 2021

lathomas commented Sep 17, 2021

tvami commented Sep 17, 2021

tvami Sep 16, 2021 •

edited