Use esConsumes in TSGFromL2Muon

[Dr15Jones]

PR description:

• Add esConsumes directly in TSGFromL2Muon
• Helper classes used by TSGFromL2Muon expanded to use esConsumes

PR validation:

Code compiles.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35327/25370

ERROR: Build errors found during clang-tidy run.

  theTTopoToken = esConsumes();
  ^
RecoMuon/TrackerSeedGenerator/plugins/TSGFromL2Muon.cc:46:19: error: no matching member function for call to 'esConsumes' [clang-diagnostic-error]
  theTTopoToken = esConsumes();
                  ^
/cvmfs/cms-ib.cern.ch/nweek-02698/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_1_X_2021-09-17-1100/src/FWCore/Framework/interface/EDConsumerBase.h:223:34: note: candidate function template not viable: no known conversion from 'TSGFromL2Muon' to 'edm::EDConsumerBase' for object argument
--
RecoMuon/TrackerSeedGenerator/plugins/TSGFromL2Muon.cc:64:46: error: use of undeclared identifier 'theTTopoToken' [clang-diagnostic-error]
  const TrackerTopology* tTopo = &es.getData(theTTopoToken);
                                             ^
RecoMuon/TrackerSeedGenerator/plugins/TSGFromL2Muon.h:41:8: error: C++ requires a type specifier for all declarations [clang-diagnostic-error]
  edm::ESTrackerTopologypology, TrackerTopologyRcd > theTTopoToken;
       ^
RecoMuon/TrackerSeedGenerator/plugins/TSGFromL2Muon.h:41:8: error: non-friend class member 'ESTrackerTopologypology' cannot have a qualified name [clang-diagnostic-error]
RecoMuon/TrackerSeedGenerator/plugins/TSGFromL2Muon.h:41:33: error: C++ requires a type specifier for all declarations [clang-diagnostic-error]
  edm::ESTrackerTopologypology, TrackerTopologyRcd > theTTopoToken;
                                ^
RecoMuon/TrackerSeedGenerator/plugins/TSGFromL2Muon.h:41:51: error: expected ';' at end of declaration list [clang-diagnostic-error]
  edm::ESTrackerTopologypology, TrackerTopologyRcd > theTTopoToken;
                                                  ^
                                                  ;
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35327/25371

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35327/25371/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35327/25371/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35327/25372

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FastSimulation/Muons (fastsim)
• RecoMuon/TrackerSeedGenerator (reconstruction)

@civanch, @lveldere, @sbein, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@HuguesBrun, @bellan, @abbiendi, @Fedespring, @calderona, @sscruz, @jhgoh, @matt-komm, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3f998/18724/summary.html
COMMIT: 7c96d7e
CMSSW: CMSSW_12_1_X_2021-09-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35327/18724/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1305 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000833
• DQMHistoTests: Total failures: 3682
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2997109
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.699 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical, no relevant reco changes (140.53 is due to DAS differences)
• I only checked the reco-related files

[sbein]

Looks like the changes in FastSimulation/* are physics-innocuous. I was a bit surprised by
https://github.com/cms-sw/cmssw/pull/35327/files#diff-54e007ef89d763e4cb77f876b32d85591a51f5a8779a13799a12b6c3c7c8b0dbL367-L374

the fairly large chunk of code just removed. It seems like in the old master, theMeasTracker was not used? I see the same change was made in the FullSim version (RecoMuon/*). Looks fine.

[sbein]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1