Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused magnetic field geometry tags from all GTs #35363

Merged
merged 1 commit into from Sep 22, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Sep 21, 2021

PR description:

This PR removes the unused

MFGeometryFileRcd | 130503 | MFGeometry_130503
MFGeometryFileRcd | 120812 | MFGeometry_120812

tags from all GTs. These tags have been superseded a long time ago by

MFGeometryFileRcd | 90322 | MFGeometry_90322
MFGeometryFileRcd | 160812 | MFGeometry_160812

but have never been removed from the GTs. See the request in [1] and the diffs in [2], they only show these 2 tags.

[1]
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4450.html

[2]
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun1_design_v1/121X_mcRun1_design_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun1_realistic_v1/121X_mcRun1_realistic_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun1_HeavyIon_v1/121X_mcRun1_HeavyIon_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_startup_v1/121X_mcRun2_startup_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_asymptotic_l1stage1_v1/121X_mcRun2_asymptotic_l1stage1_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_design_v1/121X_mcRun2_design_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_asymptotic_preVFP_v1/121X_mcRun2_asymptotic_preVFP_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_asymptotic_v1/121X_mcRun2_asymptotic_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2cosmics_asymptotic_deco_v1/121X_mcRun2cosmics_asymptotic_deco_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_HeavyIon_v1/121X_mcRun2_HeavyIon_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_pA_v1/121X_mcRun2_pA_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_v1/121X_dataRun2_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_HEfail_v1/121X_dataRun2_HEfail_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_relval_v1/121X_dataRun2_relval_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_PromptLike_HI_v1/121X_dataRun2_PromptLike_HI_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun3_HLT_v1/121X_dataRun3_HLT_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_HLT_relval_v1/121X_dataRun2_HLT_relval_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun3_Express_v1/121X_dataRun3_Express_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun3_Prompt_v1/121X_dataRun3_Prompt_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun3_v1/121X_dataRun3_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mc2017_design_v1/121X_mc2017_design_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mc2017_realistic_v1/121X_mc2017_realistic_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_forppRef5TeV_v2/120X_mc2017_realistic_forppRef5TeV_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mc2017cosmics_realistic_deco_v1/121X_mc2017cosmics_realistic_deco_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mc2017cosmics_realistic_peak_v1/121X_mc2017cosmics_realistic_peak_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_design_v1/121X_upgrade2018_design_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_realistic_v1/121X_upgrade2018_realistic_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_realistic_RD_v1/121X_upgrade2018_realistic_RD_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_realistic_HI_v1/121X_upgrade2018_realistic_HI_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_realistic_HEfail_v1/121X_upgrade2018_realistic_HEfail_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018cosmics_realistic_deco_v3/121X_upgrade2018cosmics_realistic_deco_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018cosmics_realistic_peak_v1/121X_upgrade2018cosmics_realistic_peak_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v3/121X_mcRun3_2021_design_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v4/121X_mcRun3_2021_realistic_v5
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v4/121X_mcRun3_2021cosmics_realistic_deco_v5
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v4/121X_mcRun3_2021_realistic_HI_v5
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2023_realistic_v3/121X_mcRun3_2023_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2024_realistic_v3/121X_mcRun3_2024_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun4_realistic_v1/121X_mcRun4_realistic_v2

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport and no backport is needed

resolves cms-AlCaDB/AlCaTools#20

@tvami
Copy link
Contributor Author

tvami commented Sep 21, 2021

test parameters:

  • workflows = 140.0,200.0,202.0,203.0,204.0,205.0,4001.0,4006.0,4007.0,4008.0,11634.0,12434.0,12834.0,1325.516,50200.0,7.22,145.0,281.0,10424.0,7.21,11224.0,250200.182,11024.2,7.4,12034.0,7.23,159.0,12834.0,7.24

@tvami
Copy link
Contributor Author

tvami commented Sep 21, 2021

cc @namapane

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35363/25440

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Sep 21, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce36c/18810/summary.html
COMMIT: c8594e7
CMSSW: CMSSW_12_1_X_2021-09-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35363/18810/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce36c/18810/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce36c/18810/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/140.0_HydjetQ_B12_5020GeV_2011+HydjetQ_B12_5020GeV_2011+DIGIHI2011+RECOHI2011+HARVESTHI2011
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/145.0_HydjetQ_B12_5020GeV_2015+HydjetQ_B12_5020GeV_2015+DIGIHI2015+RECOHI2015+HARVESTHI2015
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/203.0_H130GGgluonfusion+H130GGgluonfusion+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/204.0_QQH1352T+QQH1352T+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/205.0_ZTT+ZTT+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/250200.182_ZEE_13UP18_RD+ZEE_13UP18_RD+DIGIPRMXUP18_PU25_RD+RECOPRMXUP18_PU25_L1TEgDQM_RD+HARVESTUP18_PU25_L1TEgDQM_RD
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/4001.0_TTbar+TTbar+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/4006.0_SingleElectronFlatPt1To100+SingleElectronFlatPt1To100+DIGIPU1+RECOPU1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/4007.0_QCD_Pt_30_80_BCtoE_8TeV+QCD_Pt_30_80_BCtoE_8TeV+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/4008.0_QCD_Pt_80_170_BCtoE_8TeV+QCD_Pt_80_170_BCtoE_8TeV+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/50200.0_ZEE_13+ZEE_13+DIGIUP15_PU50+RECOUP15_PU50_L1TEgDQM+HARVESTUP15_PU50_L1TEgDQM
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/7.24_Cosmics_UP21_0T+Cosmics_UP21_0T+DIGICOS_UP21_0T+RECOCOS_UP21_0T+ALCACOS_UP21_0T+HARVESTCOS_UP21_0T

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 31
  • DQMHistoTests: Total successes: 3211016
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1406.726 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 46.891 KiB Info/EventInfo
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

@tvami what about 120X_mc2017_realistic_forppRef5TeV_v2? Should we remove the tags from there as well?

@francescobrivio
Copy link
Contributor

@tvami @perrotta @qliphy I also see (beside usual MessageLogger erros) some nulls in the "Info" section of wfs 312.0 and 25202.0. I don't think they are related to this PR, but I can't find anything in the logs (or maybe I'm not looking in the right place). Any suggestion?

@tvami
Copy link
Contributor Author

tvami commented Sep 22, 2021

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Sep 22, 2021

@tvami what about 120X_mc2017_realistic_forppRef5TeV_v2? Should we remove the tags from there as well?

I think we internally just agreed not to touch this

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce36c/18840/summary.html
COMMIT: c8594e7
CMSSW: CMSSW_12_1_X_2021-09-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35363/18840/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce36c/18840/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ce36c/18840/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/140.0_HydjetQ_B12_5020GeV_2011+HydjetQ_B12_5020GeV_2011+DIGIHI2011+RECOHI2011+HARVESTHI2011
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/145.0_HydjetQ_B12_5020GeV_2015+HydjetQ_B12_5020GeV_2015+DIGIHI2015+RECOHI2015+HARVESTHI2015
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/203.0_H130GGgluonfusion+H130GGgluonfusion+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/204.0_QQH1352T+QQH1352T+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/205.0_ZTT+ZTT+DIGIPU1+RECOPU1+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/250200.182_ZEE_13UP18_RD+ZEE_13UP18_RD+DIGIPRMXUP18_PU25_RD+RECOPRMXUP18_PU25_L1TEgDQM_RD+HARVESTUP18_PU25_L1TEgDQM_RD
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/4001.0_TTbar+TTbar+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/4006.0_SingleElectronFlatPt1To100+SingleElectronFlatPt1To100+DIGIPU1+RECOPU1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/4007.0_QCD_Pt_30_80_BCtoE_8TeV+QCD_Pt_30_80_BCtoE_8TeV+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/4008.0_QCD_Pt_80_170_BCtoE_8TeV+QCD_Pt_80_170_BCtoE_8TeV+DIGIPU1+RECOPUDBG
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/50200.0_ZEE_13+ZEE_13+DIGIUP15_PU50+RECOUP15_PU50_L1TEgDQM+HARVESTUP15_PU50_L1TEgDQM
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1ce36c/7.24_Cosmics_UP21_0T+Cosmics_UP21_0T+DIGICOS_UP21_0T+RECOCOS_UP21_0T+ALCACOS_UP21_0T+HARVESTCOS_UP21_0T

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 30
  • DQMHistoTests: Total successes: 3211028
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1406.73 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 46.891 KiB Info/EventInfo
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@quark2
Copy link
Contributor

quark2 commented Sep 22, 2021

FYI, this PR seems having no significant relation with PR #35335. The PR just added some more rows on an onlineDQM histogram (and fixed some typo).

Best regards,
Byeonghak Ko

@tvami
Copy link
Contributor Author

tvami commented Sep 22, 2021

  • DQMHistoTests: Total failures: 0

Yay, tests came back clear, no changes, as expected

@francescobrivio
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MFGeometry_120812 and MFGeometry_130503
5 participants