Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackToTrackComparisonHists: use correct handle to check if vertex collection is present #35353

Merged
merged 1 commit into from Sep 21, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 21, 2021

PR description:

Fix for https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/2261/2/1/2.html

PR validation:

Tested with PSets provided from Tier-0 https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/2261/2/1/2/2/1/1/1.html and patched with the new Global Tag:

process.GlobalTag.globaltag = '113X_dataRun3_Express_Candidate_2021_09_20_22_29_07'

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but a backport will be needed.

@francescobrivio
Copy link
Contributor

urgent

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35353/25420

  • This PR adds an extra 16KB to repository

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @JanFSchulte, @VinInn, @fioriNTU, @jandrea, @mtosi, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Sep 21, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adb1c4/18789/summary.html
COMMIT: d5d0c6e
CMSSW: CMSSW_12_1_X_2021-09-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35353/18789/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211080
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3211052
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 067a5ad into cms-sw:master Sep 21, 2021
@mmusich mmusich deleted the fixTrackToTrackComparisonHists branch September 21, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants