Migrating away from deprecated edm::EDAnalyzer API in CalibTracker/SiStripLorentzAngle

[mmusich]

resolves cms-AlCaDB/AlCaTools#29

PR description:

Migrating away from the deprecated edm::EDAnalyzer API in CalibTracker/SiStripLorentzAngle. Addressing the issue reported in cms-AlCaDB/AlCaTools#29

PR validation:

It compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35381/25471

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiStripLorentzAngle (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f6c54/18857/summary.html
COMMIT: 2ed97c1
CMSSW: CMSSW_12_1_X_2021-09-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35381/18857/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Added esConsumes to DynamicTruncation #35310
• @mmusich fix SiPixelCalCosmics for Run3: logical mistake in DetStatus #35371
• @Dr15Jones Use esConsumes in TSGForOIFromL2 #35324
• @Dr15Jones Added esConsumes to VirtualJetProducer classes #35276
• @tvami Remove unused magnetic field geometry tags from all GTs #35363

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f6c54/18857/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f6c54/18857/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[yuanchao]

+1

• migrate deprecated edm::EDAnalyzer (technical)
• matrix tests and unit tests passed
• other deprecated warnings are not part of this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1