fix SiPixelCalCosmics for Run3: logical mistake in DetStatus

[mmusich]

PR description:

It has been found out that the SiPixelCalCosmics ALCARECO produced exactly zero events for the full CRUZET link to DAS.
The issue has been traced to the logical mistake when migrating the DPGAnalysis/Skims/src/DetStatus.cc class to not use the DCSStatus from scalers, but from DCSRecord from the software FED #1022 to extract DCSRecord (see PR #29198).
From Run3 we won't have scalers, so the new path in the code started to be exercised only during CRUZET'21.
Since the final boolean accept was initialized to false the final result of the filter was always false leading to no events saved.

PR validation:

Tested succesfully the following cmsDriver command:

cmsDriver.py -s RAW2DIGI,RECO,ALCA:SiPixelCalCosmics --data --scenario cosmics --conditions 121X_dataRun3_Prompt_v1 --eventcontent=ALCARECO --datatier ALCARECO -n 100000 --no_exec --era Run3 --python_filename=SiPixelCalCosmics_2021_v1.py --nThreads=8 --dasquery='file dataset=/Cosmics/Commissioning2021-v1/RAW run=344421'

which was giving 0 events before and gives now:

File SiPixelCalCosmics.root Events 110
Branch Name | Average Uncompressed Size (Bytes/Event) | Average Compressed Size (Bytes/Event) 
recoMuons_muons__RECO. 5225.97 2831.74
recoTrackExtras_ALCARECOSiPixelCalCosmics__RECO. 595.264 465.6
recoTracks_ALCARECOSiPixelCalCosmics__RECO. 689.636 427.618
SiStripClusteredmNewDetSetVector_ALCARECOSiPixelCalCosmics__RECO. 787.964 403.218
SiPixelClusteredmNewDetSetVector_ALCARECOSiPixelCalCosmics__RECO. 492.236 365.427
TrackingRecHitsOwned_ALCARECOSiPixelCalCosmics__RECO. 2010.9 306.336
recoCaloMuons_muons__RECO. 354 238.782
EventAuxiliary 118.6 40.5727
edmTriggerResults_TriggerResults__HLT. 172.436 28.9091
EventProductProvenance 870.864 22.8182
EventSelections 78.6455 4.81818
BranchListIndexes 25.7364 3.01818

I profit of this PR to change the AndOr in the configuration to take the OR of the BPIx and FPix DCS bits, instead of the AND after consultation with the pixel offline group.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but a backport will be needed for 12.0.X

[mmusich]

type bug-fix

[mmusich]

urgent

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35371/25449

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Calibration/TkAlCaRecoProducers (alca)
• DPGAnalysis/Skims (pdmv)

@malbouis, @yuanchao, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @kskovpen, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• workflows = 7.2, 7.21, 7.22, 7.23, 7.24, 7.3, 7.4, 134.813, 136.733, 138.1, 138.2

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62e3ab/18837/summary.html
COMMIT: fc664d0
CMSSW: CMSSW_12_1_X_2021-09-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35371/18837/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-62e3ab/134.813_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-62e3ab/136.733_RunCosmics2016B+RunCosmics2016B+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-62e3ab/138.1_RunCosmics2021+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-62e3ab/138.2_RunCosmics2021+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-62e3ab/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-62e3ab/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-62e3ab/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-62e3ab/7.24_Cosmics_UP21_0T+Cosmics_UP21_0T+DIGICOS_UP21_0T+RECOCOS_UP21_0T+ALCACOS_UP21_0T+HARVESTCOS_UP21_0T

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[bbilin]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1