New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating away from deprecated edm::EDAnalyzer API in CalibTracker/SiPixelESProducers #35375
Migrating away from deprecated edm::EDAnalyzer API in CalibTracker/SiPixelESProducers #35375
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35375/25455
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
5f3f5a7
to
43b56e9
Compare
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35375/25458
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
43b56e9
to
16a1f93
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35375/25460
|
A new Pull Request was created by @ferencek (Dinko F.) for master. It involves the following packages:
@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae2020/18848/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Migrating away from the deprecated
edm::EDAnalyzer
API inCalibTracker/SiPixelESProducers/interface/SiPixelDetInfoFileWriter.h
. Addressing the issue reported in cms-AlCaDB/AlCaTools#33PR validation:
No special validation done other than checking that the code compiles. None of the production code is touched, no changes expected in the output.
@tvami