Bug fix for Esinput tag creation in PCaloGeometryBuilder

[sroychow]

PR description:

This fixes incorrect syntax in creating an ESInputTag in CondTools/​Geometry/​plugins/​PCaloGeometryBuilder.cc as reported in comment

PR validation:

Compiles and test config CondTools/Geometry/test/calogeometry2026writer.py runs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35430/25560

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

• CondTools/Geometry (db)

@ggovi, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@cvuosalo, @mmusich, @bsunanda this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[sroychow]

@cmsbuild please test

[cvuosalo]

type bug-fix

[cvuosalo]

I tested this PR and verified it fixes the exception that was occurring.

[cvuosalo]

@civanch FYI. This PR fixes the problem I encountered while creating the DDD geometry DB payload today.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37f487/19146/summary.html
COMMIT: b81c436
CMSSW: CMSSW_12_1_X_2021-09-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35430/19146/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• differences are only in the msg logger

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• bug fix