Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed solution to ECAL emulator PR issue #35557

Merged
merged 12 commits into from Oct 14, 2021
Merged

Proposed solution to ECAL emulator PR issue #35557

merged 12 commits into from Oct 14, 2021

Commits on Sep 28, 2021

  1. Changed ECAL emulator debug and TPinfo cout print statements to LogVe… 

    …rbatim
    @atishelmanch
    atishelmanch committed Sep 28, 2021
    Copy the full SHA
    1798695 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Added string pointer destruction, updated log info a bit

    @atishelmanch
    atishelmanch committed Sep 29, 2021
    Copy the full SHA
    52ae7b0 View commit details
    Browse the repository at this point in the history

  2. Cleaning up and improving EcalTPG verbatim statements

    @atishelmanch
    atishelmanch committed Sep 29, 2021
    Copy the full SHA
    6628373 View commit details
    Browse the repository at this point in the history

  3. Combining a few EcalTPG LogVerbatim lines

    @atishelmanch
    atishelmanch committed Sep 29, 2021
    Copy the full SHA
    d2c82e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Rethrowing EcalCondDB and CondTool catches as cms Exceptions

    @atishelmanch
    atishelmanch committed Oct 1, 2021
    Copy the full SHA
    0fefcf4 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Reverted test executables, and replaced couts with loginfo

    @atishelmanch
    atishelmanch committed Oct 4, 2021
    Copy the full SHA
    db012a6 View commit details
    Browse the repository at this point in the history

  2. CMSSW code checks and code format

    @atishelmanch
    atishelmanch committed Oct 4, 2021
    Copy the full SHA
    1936292 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Replaced many EcalTPG loginfo statements with logverbatim statements

    @atishelmanch
    atishelmanch committed Oct 5, 2021
    Copy the full SHA
    1cee3ab View commit details
    Browse the repository at this point in the history

  2. Reran CMSSW code checks and code format

    @atishelmanch
    atishelmanch committed Oct 5, 2021
    Copy the full SHA
    5960e9e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Updated ECAL TPGmode printout formatting, introduced either smart poi… 

    …nters or bare pointer deletions
    @atishelmanch
    atishelmanch committed Oct 8, 2021
    Copy the full SHA
    e986346 View commit details
    Browse the repository at this point in the history

  2. Replaced one extra exit statement with a cms exception

    @atishelmanch
    atishelmanch committed Oct 8, 2021
    Copy the full SHA
    2b68e21 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Removing ECAL delete statements to revert to known working version. A… 

    …dded a single character in ECALTPG log output
    @atishelmanch
    atishelmanch committed Oct 11, 2021
    Copy the full SHA
    912bc18 View commit details
    Browse the repository at this point in the history