Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEMGeometryBuilder bugfix #35855

Merged
merged 1 commit into from Oct 27, 2021
Merged

GEMGeometryBuilder bugfix #35855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion Geometry/GEMGeometryBuilder/src/GEMGeometryBuilder.cc
View file
Open in desktop
Expand Up @@ -524,8 +524,9 @@ void GEMGeometryBuilder::buildRegions(GEMGeometry& theGeometry, const std::vecto
auto chamber = theGeometry.chamber(chId);
if (!chamber) {
edm::LogWarning("GEMGeometryBuilder") << "Missing chamber " << chId;
} else {
superChamber->add(chamber);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jshlee
I am confused a bit on the PR description and code changes. It seems the original code already protect non-exisitng chamber already. This PR seems to add existing chamber to super chamber. What will happen if you don't add chamber to superChamber (i.e. now)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original code would just send the logwarning if the chamber is invalid and still add it to the superchamber.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK. I miss line 528 of the original code. Thanks.

}
superChamber->add(chamber);
}
ring->add(superChamber);
theGeometry.add(superChamber);
Expand Down