Improve DQM beamspot clients

[francescobrivio]

PR description:

Forward port of #35918

Updates to the Legacy and HLT BeamSpot DQM clients:

• Fixed the names of the output DQM folder so that the DQM is more clear:
  • 1 folder for BeamMonitorLegacy
  • 1 folder for BeamMonitorLHT
  • previous BeamMonitor folder is removed
• Added the offline <-> online beamspot swap same as in express and HLT
• In the BeamSpot Legacy clients I also fixed the pixelTracksTrackingRegions parameters to remove the 2018 HI customization that was left there (thanks @mmusich!). Overall this should increase the number of tracks reconstructed by the Legacy client so that it can fit PVs and eventually the Beamspot.
• Fixed a typo in the name of the Legacy BeamSpotOnline tag

[Important Note]
This PR contains an additional commit to remove the following customization in the BeamSpot Legacy DQM client:

process.pixelTracksTrackingRegions.RegionPSet.ptMin = 0.1

This customization was used in 12_0_X during PilotBeam 2021 data taking due to the special collision conditions, but should not be applied for standard collision.

PR validation:

Validated with DQM playback system and also during data-taking, see #35918 (comment) and #35918 (comment) for the outcome of the data-taking.

Backport

A backport to 12_0_X is provided in #35918
A backport to 12_1_X is provided in #35935

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35932/26336

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py modified in PR(s): Fix era for DQM BeamSpot clients #35898
  • File DQM/Integration/python/clients/beamhlt_dqm_sourceclient-live_cfg.py modified in PR(s): Fix era for DQM BeamSpot clients #35898

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[emanueleusai]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-116532/20171/summary.html
COMMIT: fcf791a
CMSSW: CMSSW_12_2_X_2021-11-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35932/20171/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901868
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[jfernan2]

please test with #35921

[perrotta]

please abort
(no need to rerun all tests only to get rid of a unit test error, already fixed in the IB)

[perrotta]

... unless you @jfernan2 really wanted to test that unit test!
Please let me know if I misunderstood your intentions (and apologize if so)

[jfernan2]

Thanks @perrotta
Since this PR is affecting DQM/Integration where UnitTests are, this was a way to check if this PR was consistent with its backports (beyond an eye inspection from my side), but it is fine, no problem.

[perrotta]

+1

• Identical to [12_0_X] Improve DQM beamspot clients #35918, which was already merged in 12_0_X to be used in the latest data taking with beams

[jfernan2]

+1
Tested in Online DQM at P5

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

[perrotta]

merge

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-116532/20190/summary.html
COMMIT: fcf791a
CMSSW: CMSSW_12_2_X_2021-11-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35932/20190/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2901861
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found