add SOI check to HBHEPhase1Reconstructor

[wang-hui]

PR description:

This PR is to fix a crash in HBHEPhase1Reconstructor as reported in #35785

The reason of the crash is an out_of_range index "soi" of the vector "inputCharge" in M3 reconstruction
To prevent similar crashes in the future, a check of SOI and max TS has been added to HBHEPhase1Reconstructor
maxTS >= 3 && soi > 0 && soi < maxTS - 1
If this check fails, an edm::LogWarning will be generated and the corresponding channel will be dropped in HBHE reconstruction.

PR validation:

I followed PRWorkflow for the PR validation.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35944/26349

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35944/26349/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35944/26349/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35944/26350

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @wang-hui for master.

It involves the following packages:

• RecoLocalCalo/HcalRecProducers (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@apsallid, @mariadalfonso, @abdoulline, @bsunanda this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ef220/20166/summary.html
COMMIT: 2f10d59
CMSSW: CMSSW_12_2_X_2021-11-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35944/20166/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901868
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35944 2f10d59

• code changes are in line with the PR description: the hit with soi outside of the range will be skipped now
• jenkins tests pass without differences in comparisons with the baseline (the condition is not expected in the bot tests anyways)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1