-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SOI check to HBHEPhase1Reconstructor #35944
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35944/26349
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35944/26350
|
A new Pull Request was created by @wang-hui for master. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ef220/20166/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is to fix a crash in HBHEPhase1Reconstructor as reported in #35785
The reason of the crash is an out_of_range index "soi" of the vector "inputCharge" in M3 reconstruction
To prevent similar crashes in the future, a check of SOI and max TS has been added to HBHEPhase1Reconstructor
maxTS >= 3 && soi > 0 && soi < maxTS - 1
If this check fails, an edm::LogWarning will be generated and the corresponding channel will be dropped in HBHE reconstruction.
PR validation:
I followed PRWorkflow for the PR validation.