Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BTV OfflineDQM preparations for Run 3 #35985
BTV OfflineDQM preparations for Run 3 #35985
Changes from 22 commits
8a4c9c8
3aea6b7
1b3b533
0365c0b
533e06a
280040f
0e53310
f686f58
e57ad02
826273d
cf6d945
6dfddb9
b88fb50
e6a81d9
6eca77f
87b4db8
198558a
e3cd8d7
4d6881d
e6c4ea3
8eab003
a0b411a
db43d9e
696c60c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still miss why do you want to add to histograms even when the list of discriminators is empty: is this really needed?
Shouldn't you more conveniently initialize
float denominator = 0;
and avoid adding to histo if there are no denominators?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is used for
BvsAll
. In this case the denominator is the sum of all probabilities.So instead of summing up all probabilities to numerically 1 in the loop, the denominator is set to 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now I understand, thank you.
Still, wouldn't it be more intutitive if in that case the first string in
discrDenominator_
is set as (e.g.) "ALL"? With empty lists one normally expects no elements insides, not "the sum of all probabilities"...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be intuitive but requires a check for an empty list and a comparison between strings in each event. As the denominator list cannot be empty anyways I think it's a good way to interpret empty lists as no division performed.
I'll add a comment to explain this case.