Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTV OfflineDQM preparations for Run 3 #35985

Merged
merged 24 commits into from Nov 16, 2021
Merged

BTV OfflineDQM preparations for Run 3 #35985

merged 24 commits into from Nov 16, 2021

Conversation

marco-link
Copy link
Contributor

PR description:

  • add DeepJet to @miniAODDQM
  • move DeepCSV to @miniAODDQM
  • update DeepCSV WPs

Changes presented in the Btag WG Meeting

PR validation:

runTheMatrix.py -l 12034.0 to verify histograms are filled correctly

runTheMatrix.py -l limited -i all

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35985/26415

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35985/26643

@cmsbuild
Copy link
Contributor

Pull request #35985 was updated. @perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @qliphy, @davidlange6, @fabiocos, @pbo0, @rvenditti can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19a9e1/20548/summary.html
COMMIT: 696c60c
CMSSW: CMSSW_12_2_X_2021-11-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35985/20548/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3314358
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3314329
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2753.077 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.589 KiB Btag/DeepFlavour_BvsAll_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.581 KiB Btag/DeepFlavour_BvsAll_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.581 KiB Btag/DeepFlavour_CvsB_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.581 KiB Btag/DeepFlavour_CvsL_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.573 KiB Btag/DeepCSV_BvsAll_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.573 KiB Btag/DeepFlavour_CvsB_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): 0.573 KiB Btag/DeepFlavour_CvsL_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): -0.573 KiB Btag/deepCSV_BvsAll_ETA_1v4-2v5
  • DQMHistoSizes: changed ( 1000.0 ): 0.569 KiB Btag/DeepFlavour_BvsAll_GLOBAL
  • DQMHistoSizes: changed ( 1000.0 ): 0.565 KiB Btag/DeepCSV_BvsAll_ETA_0-1v4
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: found differences in 24 / 41 workflows

@jfernan2
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants