fix for testPhase2PixelNtuple unit test
#36019
Conversation
|
type bugfix |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36019/26468
|
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
please abort somehow I don't see any tests running, trying to restart them |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0011ad/20297/summary.html Comparison SummarySummary:
|
| @@ -111,8 +111,11 @@ | |||
| #process.FEVTDEBUGHLToutput_step = cms.EndPath(process.FEVTDEBUGHLToutput) | |||
|
|
|||
| # Schedule definition | |||
| process.schedule = cms.Schedule(process.digitisation_step,process.L1simulation_step,process.L1TrackTrigger_step,process.digi2raw_step) | |||
| process.schedule.extend(process.HLTSchedule) | |||
There was a problem hiding this comment.
Do you not need HLTSchedule anymore?
There was a problem hiding this comment.
Not anymore. After #35858, process.schedule already holds the HLT Paths previously provided by HLTSchedule in configs such as this one (see the comment # process.schedule imported from cff in HLTrigger.Configuration one line below).
|
+Upgrade Fixing of unit test as described in the PR description. |
|
@cms-sw/geometry-l2 Any comment? |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR fixes a unit test of
SLHCUpgradeSimulations/Geometrythat stopped working after the integration of #35858(see discussion in the latter for some more details).
PR validation:
The relevant cfg file now works (the unit test itself fails locally due to the input file not being available anymore).
If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A