Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to new method in PoolDBOutputService for SiPixel CPE #36027

Merged
merged 2 commits into from Nov 9, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Nov 7, 2021

PR description:

Change to new method of writeOneIOV in PoolDBOutputService for SiPixel CPE. This also meant changing the pointers to the instance of the object.

As part of cms-AlCaDB/AlCaTools#28

PR validation:

scramv1 b runtests run fine

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36027/26481

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2021

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • CondTools/SiPixel (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Nov 7, 2021

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Nov 7, 2021

cc @SanjanaSekhar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36027/26482

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2021

Pull request #36027 was updated. @cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Nov 7, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2021

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a090e3/20315/summary.html
COMMIT: 5e7d5b6
CMSSW: CMSSW_12_2_X_2021-11-07-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36027/20315/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 07-Nov-2021 21:53:42 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'EcalBarrelGeometryEPdd4hep' in category 'CMS EDM Framework ParameterSet Description'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

@tvami
Copy link
Contributor Author

tvami commented Nov 7, 2021

@cmsbuild , please test with #36021

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a090e3/20317/summary.html
COMMIT: 5e7d5b6
CMSSW: CMSSW_12_2_X_2021-11-07-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36027/20317/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 2694541
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2694513
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 40 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 173 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Nov 8, 2021

@tvami
Copy link
Contributor Author

tvami commented Nov 8, 2021

+db

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 9, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants