Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_2_X #36034

Merged
merged 1 commit into from Nov 8, 2021

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Nov 8, 2021

PR description:

Development of HLT menus for CMSSW_12_2_X. Includes the integration of the following JIRA tickets:

  • CMSHLT-2189: technical fix for Tracker-DCS info in Run-3
  • CMSHLT-2194: bugfix for parameter hltHtMhtCaloJetsFiveC25.minNJetHt (affects 3 triggers in GRun)

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36034/26489

  • This PR adds an extra 824KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Nov 8, 2021

please test with #36021

looks like this other unrelated PR is necessary to fix some of the PR tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-111887/20334/summary.html
COMMIT: 021245f
CMSSW: CMSSW_12_2_X_2021-11-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36034/20334/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 2694539
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694492
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 173 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: found differences in 4 / 40 workflows

@missirol
Copy link
Contributor Author

missirol commented Nov 8, 2021

+hlt

  • despite the label, this PR did not require any externals
    (another PR was needed to work around an unrelated issue in PR tests)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 8, 2021

+1

@cmsbuild cmsbuild merged commit 45696b7 into cms-sw:master Nov 8, 2021
@missirol missirol deleted the HLTdevelopment122X branch November 9, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants