remove unnecessary check in HLT-DQM module #36126
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36126/26636
|
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@Martin-Grunewald, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
| @@ -481,7 +481,7 @@ void HLTObjectsMonitor::analyze(const edm::Event& iEvent, const edm::EventSetup& | |||
| if (key != key1 && | |||
| kCnt1 > kCnt0) { // avoid filling hists with same objs && avoid double counting separate objs | |||
|
|
|||
| double pt2 = objects[key1].phi(); | |||
| double pt2 = objects[key1].pt(); | |||
| double eta2 = objects[key1].eta(); | |||
| double phi2 = objects[key1].phi(); | |||
| int id2 = objects[key1].id(); | |||
There was a problem hiding this comment.
One note (maybe just to myself) which goes a bit beyond this PR.
I was trying to figure out why the original warning quoted 89 and 0 as "object IDs", while the trigger-IDs of the objects created by HLTHtMhtFilter are 89 and 90 [1] [2].
The answer is in the implementation of TriggerSummaryProducerAOD, and the bottom line is that one can get the correct IDs using TriggerEvent::filterIds (in analogy to TriggerEvent::filterKeys), instead of relying on TriggerObject::id (which is what is currently done in this DQM module). Martin can correct me if I misunderstood this.
|
The PR tests seem stuck on |
|
@missirol , there was some problem with build nodes which is fixed now. addon job is running now |
|
Thanks, @smuzaffar ! |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8eba43/20531/summary.html Comparison SummarySummary:
|
|
+1 |
|
+hlt |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR removes an unnecessary check in a DQM module related to HLT.
It addresses #23200 (more details can be found in the latter issue).
It also includes a small bugfix found along the way. The latter might lead to differences in some DQM outputs (1 ME of
HLTObjectsMonitor).PR validation:
scrambuilds.If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A