New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracker Alignment] update split vertex validation #36178
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36178/26744
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6bded/20624/summary.html Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The purpose of this PR is to update the codes for the Split Vertex validation used in Tracker Alignment to make the x-axis limits of the trend plots vs vertex sumPt and the binnings of the profiles vs #tracks and #vertices to be configurable.
The current setup is sort of hardcoded and optimized for the 13TeV collisions and this was a shortcoming found during the validation of the alignment candidates for the Fall 2021 LHC beam test at sqrt=900GeV.
The configurability is percolated all the way down to the all-in-one meta-tool and some checks on the coincidence of the x-axis setup are introduced in the plotting macro
FitPVResolution
.I profit of this PR to introduce
fillDescriptions
method toSplitVertexResolution
.PR validation:
Private. Some results are available here
as example:
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A