Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3syntaxupgrade #36160

Closed
wants to merge 98 commits into from

Conversation

conetthuerta
Copy link
Contributor

@conetthuerta conetthuerta commented Nov 17, 2021

PR description:

~/CMSSW_12_0_1/src/Validation/Geometry/test/MaterialBudget.py is updated;

  • Syntax is upgraded from Python2 to Python3, this is necessary as per the migration to Python3 (MaterialBudget.py will not run without these changes).
  • No dependency on any other PR's or externals.
  • https://www.python.org/download/releases/3.0/

PR validation:

Tracker Material Budget Validation was run with CMSSW_12_0_1 (https://twiki.cern.ch/twiki/bin/viewauth/CMS/TrackerMaterialBudgetValidation - TWiki needs to be updated), "Validation plots: single geometry configuration" were produced (.png and .pdf files that illustrate the tracker material budget, measured in fractional radiation lengths x or hadronic interaction lengths l, plotted as a function of eta, or phi, or R, or eta and phi, etc.).

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

fwyzard and others added 30 commits July 31, 2021 09:25
…_for_python3

Fix integer division after migration to python 3
…tSetup_filling

Fix uploading EventSetup conditions from multiple CUDA streams [12.0.x]
…nebeammonitor_12_0_X

 Update DQM onlinebeammonitor [12_0_X]
NANO: rework for Prompt (part2) backport
Run3-hcx306X Bug fix (backport cms-sw#34738) to HCAL SD class
…pre5

HLT menu migration to CMSSW 12_0_0_pre5 template [12_0_X]
Fix crash of ECAL GPU reco when ECAL is out of the run - 12_0_X
[Backport] GEM dataformat - fix classversion
…_for_empty_events_120x

Protect HCAL GPU-related modules against empty events [12.0.x]
…ing_backport_12_0_X_2021-08-10-1100

Pixel cluster repair by morphing backport to 12_0_X
…entOfflineValidation_allInOneTool_12_0_X

[12.0.X] Miscellaneous fixes to  `Alignment/OflineValidation` all-in-one tool
…nite_fix_12_X

[12_0_X] Fix rare crash in pixel template interpolation
Add HCAL tag HcalRespCorrs_2021_v3.0_mc
@cmsbuild
Copy link
Contributor

@missirol
Copy link
Contributor

@conetthuerta, I'd suggest to close this PR.

(it seems #36164 supersedes this one)

@slava77
Copy link
Contributor

slava77 commented Nov 18, 2021

-1

@mariadalfonso
Copy link
Contributor

-1

@Martin-Grunewald
Copy link
Contributor

-1
likely a rebase needed.

@conetthuerta
Copy link
Contributor Author

@missirol PR closed as per your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment