Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of last mentions of "HLTSchedule" #36395

Merged
merged 2 commits into from Dec 9, 2021

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Dec 7, 2021

PR description:

Part of #35842. This PR removes the last mentions of the object "HLTSchedule".

The most important change is the removal of the internal renaming which was temporarily needed inside one of the customisations maintained by HLT.

The other changes are simply cleanup of test/ configs that unnecessarily use the name "HLTSchedule" (these are cleanups I missed in #36073); please note that some of these configs are old, and already broken anyways for unrelated reasons; still, mentions to HLTSchedule are removed, in the interest of clarity.

Merely technical. No changes expected.

PR validation:

Unit-tests and addOnTests passed. Verified that the affected test/ configs continue to work if they were working already.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

This is a cleanup PR, not a bugfix, so no backport to 12_2_X is planned (could be done if that's preferred).

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36395/27197

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • Calibration/IsolatedParticles (alca)
  • HLTrigger/Configuration (hlt)
  • RecoLuminosity/LumiProducer (reconstruction)
  • Validation/HGCalValidation (dqm)

@malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @missirol, @jfernan2, @Martin-Grunewald, @slava77, @jpata, @francescobrivio, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@cseez, @vandreev11, @sethzenz, @bsunanda, @silviodonato, @rovere, @lgray, @Martin-Grunewald, @apsallid, @pfs, @lecriste, @hatakeyamak, @tocheng, @mmusich, @ebrondol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Dec 7, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f67e9/21061/summary.html
COMMIT: c90e606
CMSSW: CMSSW_12_3_X_2021-12-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36395/21061/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250580
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Dec 7, 2021

+alca

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 7, 2021

+1

@missirol
Copy link
Contributor Author

missirol commented Dec 8, 2021

+hlt

@slava77
Copy link
Contributor

slava77 commented Dec 9, 2021

+reconstruction

for #36395 c90e606

  • code changes in reco are only in RecoLuminosity/LumiProducer/test/validation/fastsimSampleWithHLT_1E31_cfg.py and are in line with the PR description/title
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 9, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants