Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed refs to HLTSchedule outside of HLTrigger/Configuration #36073

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

missirol
Copy link
Contributor

PR description:

This PR is a minor technical follow-up of #35858 related to this comment.

Given the plan to remove the object HLTSchedule in the near future (see #35842), the usage of HLTSchedule is removed in various configuration files, mostly in test/ folders.

PR validation:

Verified that the affected configs are fixed if they were crashing b/c of HLTSchedule.
Most of these configs are old and already broken anyways for unrelated reasons
(still, references to HLTSchedule are removed there too, in the interest of clarity).

Unit tests passed.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36073/26547

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • Calibration/IsolatedParticles (alca)
  • FastSimulation/Calorimetry (fastsim)
  • FastSimulation/Validation (fastsim)
  • HLTrigger/special (hlt)
  • HLTriggerOffline/Tau (dqm)
  • L1Trigger/L1TCommon (l1)
  • L1Trigger/L1TMuonCPPF (l1)
  • RecoParticleFlow/Configuration (reconstruction)
  • SLHCUpgradeSimulations/Configuration (upgrade, simulation)
  • SimG4Core/Configuration (simulation)
  • Validation/RecoHI (dqm)

@lveldere, @slava77, @Martin-Grunewald, @rekovic, @cecilecaillol, @civanch, @yuanchao, @ahmad3213, @cmsbuild, @missirol, @pmandrik, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @sbein, @jpata, @pbo0, @francescobrivio, @malbouis, @ssekmen, @srimanob, @rvenditti, @tvami can you please review it and eventually sign? Thanks.
@kpedro88, @Martin-Grunewald, @bsunanda, @thomreis, @slomeo, @mmarionncern, @makortel, @JanFSchulte, @lgray, @seemasharmafnal, @cvuosalo, @tocheng, @kkrajczar, @rovere, @VinInn, @simonepigazzini, @sviret, @hatakeyamak, @mmusich, @mtosi, @fabiocos, @silviodonato, @RylanC24, @cbernet, @dinyar, @matt-komm this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c41939/20433/summary.html
COMMIT: 3707caf
CMSSW: CMSSW_12_2_X_2021-11-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36073/20433/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901868
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Nov 10, 2021

+alca

@jfernan2
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

Clean up PR, no change is expected.

@civanch
Copy link
Contributor

civanch commented Nov 10, 2021

+1

@missirol
Copy link
Contributor Author

+hlt

@slava77
Copy link
Contributor

slava77 commented Nov 11, 2021

+reconstruction

for #36073 3707caf

  • code changes in reco are only in RecoParticleFlow/Configuration/test/IntegrationTestWithHLT_cfg.py, in agreement with the title/description

@qliphy
Copy link
Contributor

qliphy commented Nov 15, 2021

ping @cms-sw/l1-l2

@qliphy
Copy link
Contributor

qliphy commented Nov 17, 2021

please test
retest and ping @cms-sw/l1-l2

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c41939/20578/summary.html
COMMIT: 3707caf
CMSSW: CMSSW_12_2_X_2021-11-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36073/20578/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3320802
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3320774
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Nov 17, 2021

please test retest and ping @cms-sw/l1-l2

@qliphy maybe we can merge w/o the L1 signature? It's a "minor technical follow-up" after all :)

@qliphy
Copy link
Contributor

qliphy commented Nov 17, 2021

merge

@cmsbuild cmsbuild merged commit 9e3204e into cms-sw:master Nov 17, 2021
@missirol missirol deleted the devel_cleanHLTSchedule branch December 7, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment