Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Candidate GT by named GT in conddb script unit tests and update offline Run-3 data GT #36402

Merged
merged 2 commits into from Dec 8, 2021

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Dec 7, 2021

PR description:

This PR has two updates:

The difference in the run-3 data offline GT wrt the previous version is shown below. the only differences are in the 16 updated multi-IOV tags that contain related to ECAL PC Cluster corrections:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/122X_dataRun3_v2/122X_dataRun3_v3

PR validation:

For the conddb unit tests: scram b runtests_test_conddb

For the offline Run-3 data GT: runTheMatrix.py -l 136.897,136.899,138.3,139.001,139.002,139.003,139.004 -j16

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport but it will be backported to 122X, 121X and 120X.

@malbouis
Copy link
Contributor Author

malbouis commented Dec 7, 2021

test parameters:

  • workflows=136.897,136.899,138.3,139.001,139.002,139.003,139.004

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36402/27207

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

A new Pull Request was created by @malbouis for master.

It involves the following packages:

  • CondCore/Utilities (db)
  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

malbouis commented Dec 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3aa6f2/21071/summary.html
COMMIT: d093cd6
CMSSW: CMSSW_12_3_X_2021-12-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36402/21071/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3aa6f2/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3aa6f2/136.899_RunCosmics2021CRAFT+RunCosmics2021CRAFT+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3aa6f2/138.3_Splashes+RunMinimumBias2021Splash+COPYPASTER3+RECODR3Splash+HARVESTDR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3aa6f2/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3aa6f2/139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3aa6f2/139.003_RunHLTPhy2021+RunHLTPhy2021+HLTDR3_2021+RECODR3_HLTPhysics_Offline+HARVESTD2021HLTPhy
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3aa6f2/139.004_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250574
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Dec 7, 2021

+1

  • modified unit tests pass
  • new GT is just rather here for documentation

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 8, 2021

+1

@mmusich
Copy link
Contributor

mmusich commented Dec 8, 2021

@malbouis @tvami,
if you really intend to pursue the deletion of candidate GlobalTags older than 6 months, please notice that in addition to PR #36409 you'll also need backports of commit 8ac2135 all the way down to 12.0.X as the unit test test_conddb was introduced first there:

conddb diff 120X_mcRun3_2021_realistic_v1 120X_mcRun3_2021_realistic_Candidate_2021_06_09_14_33_50 || die 'conddb diff' $?

conddb diff 120X_mcRun3_2021_realistic_v1 120X_mcRun3_2021_realistic_Candidate_2021_06_09_14_33_50 || die 'conddb diff' $?

@malbouis
Copy link
Contributor Author

malbouis commented Dec 8, 2021

@malbouis @tvami, if you really intend to pursue the deletion of candidate GlobalTags older than 6 months, please notice that in addition to PR #36409 you'll also need backports of commit 8ac2135 all the way down to 12.0.X as the unit test test_conddb was introduced first there:

@mmusich Thanks for pointing that out! I updated the description of this PR to include all the the backports that are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants