DBOutputService: Removed deprecated methods

[ggovi]

PR description:

The PoolDBoutputService interface (and its Derived class OnlineDBOutputService ) contains methods that have been deprecated in favour of new methods providing the same functionalities with a more explicit signature concerning the payload object ownership policy. Since all of the clients of the old interface in CMSSW have been migrated to the new interface, in this PR we proceed to remove the deprecated methods.

PR validation:

Unit and integration tests

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36466/27320

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @ggovi for master.

It involves the following packages:

• CondCore/DBOutputService (db, alca)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[ggovi]

please test

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b92292/21213/summary.html
COMMIT: 761bb10
CMSSW: CMSSW_12_3_X_2021-12-12-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36466/21213/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

  106 |     static const std::string& extendedBaseType(EDAnalyzer const*) { return kExtendedBaseForEDAnalyzer; }
      |                                                                 ^
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-12-0000/src/DQM/DTMonitorClient/src/DTSummaryClients.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-12-0000/src/DQM/DTMonitorClient/src/DTLocalTriggerSynchTest.cc:24:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-12-0000/src/CalibMuon/DTCalibration/interface/DTCalibDBUtils.h: In static member function 'static void DTCalibDBUtils::writeToDB(std::string, T*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-12-0000/src/CalibMuon/DTCalibration/interface/DTCalibDBUtils.h:35:24: error: 'class cond::service::PoolDBOutputService' has no member named 'writeOne'; did you mean 'writeOneIOV'?
   35 |           dbOutputSvc->writeOne(payload, dbOutputSvc->beginOfTime(), record);
      |                        ^~~~~~~~
      |                        writeOneIOV
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2021-12-12-0000/src/CalibMuon/DTCalibration/interface/DTCalibDBUtils.h:35:34: error: expected primary-expression before '>' token
   35 |           dbOutputSvc->writeOne(payload, dbOutputSvc->beginOfTime(), record);


[mmusich]

after merging of #36366 this needs a rebase (file RecoEgamma/EgammaTools/test/GBRWrapperMaker.cc has already been taken care of)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36466/27334

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibMuon/DTCalibration/plugins/DTTTrigCorrection.cc modified in PR(s): Modernize use of EDModules for CalibMuon/DTCalibration #36434

[cmsbuild]

Pull request #36466 was updated. @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @ggovi, @jfernan2, @clacaputo, @slava77, @jpata, @francescobrivio, @pbo0, @rvenditti can you please check and sign again.

[yuanchao]

@cmsbuild please test

[tvami]

This branch has conflicts that must be resolved

@yuanchao tests should have been started after conflicts are resolved. @ggovi I think you'll need to rebase to a later release (tho it seems today's IB is actually broken, so maybe rebase tomorrow)

[perrotta]

Please rebase on top of latest CMSSW_12_3_X_2021-12-13-2300, which contains the conflicting PR #36366
It is not broken, as far as I can see...

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b92292/21249/summary.html
COMMIT: 9972b7a
CMSSW: CMSSW_12_3_X_2021-12-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36466/21249/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testCondToolsSiStripBuildersReaders had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250704
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3250670
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[ggovi]

Replaced by #36490

[tvami]

-1

• PR is closed