Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gem65 Add the demonstration chamber of RPC for the Run3 scenario #36486

Merged
merged 1 commit into from Dec 18, 2021

Conversation

bsunanda
Copy link
Contributor

PR description:

Add the demonstration chamber of RPC for the Run3 scenario

PR validation:

Use overlap testing tool to check for overlaps

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36486/27361

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/MuonCommonData (geometry)
  • Geometry/MuonSimData (geometry)
  • Geometry/RPCGeometryBuilder (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ptcox, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-461080/21260/summary.html
COMMIT: cb75639
CMSSW: CMSSW_12_3_X_2021-12-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36486/21260/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250704
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250676
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@@ -20,8 +20,10 @@
<PartSelector path="//YE1.*"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is not in the DB yet, so it is safe to modify.

@cvuosalo
Copy link
Contributor

What are the plans for Geometry/MuonSimData/data/v2/muonSens.xml?

@bsunanda
Copy link
Contributor Author

It is just a reference - what is in Run3 right now - from that we grow to v3 (include GE21 demonstration) and v4 (also include RPC RR3X and RR4X)

@cvuosalo
Copy link
Contributor

@bsunanda With this PR there are two identical files in different directories:

Geometry/MuonSimData/data/v2/muonSens.xml
Geometry/MuonSimData/data/muonSens/2021/v2/muonSens.xml

Can Geometry/MuonSimData/data/v2/muonSens.xml be deleted and all references to it be changed?

@bsunanda
Copy link
Contributor Author

@cvuosalo Yes I shall do that in a separate PR. I did not want to touch that here

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 18, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants