Remove unused MASS_POINT and SLHA_FILE from Exotica_HSCP_SIM_cfi

[tvami]

PR description:

Tau-prime samples dont have SLHA inputs [1], but when doing a GEN-SIM campaign the SIM part for the costumization looks for a value, that is never used after all, and so the cmsDriver command cannot be built.

[1] https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_fragment/EXO-RunIISummer20UL17GENSIM-00002

PR validation:

Running

cmsDriver.py Configuration/GenProduction/python/EXO-RunIISummer20UL17GENSIM-00002-fragment.py --python_filename EXO-RunIISummer20UL17GENSIM-00002_1_cfg.py --eventcontent RAWSIM --customise SimG4Core/CustomPhysics/Exotica_HSCP_SIM_cfi.customise,Configuration/DataProcessing/Utils.addMonitoring --datatier GEN-SIM --fileout file:EXO-RunIISummer20UL17GENSIM-00002.root --conditions 106X_mc2017_realistic_v6 --beamspot Realistic25ns13TeVEarly2017Collision --customise_commands process.source.numberEventsInLuminosityBlock="cms.untracked.uint32(100)" --step GEN,SIM --geometry DB:Extended --era Run2_2017 --no_exec --mc -n 10

if this PR is a backport please specify the original PR and why you need to backport that PR:

It's a partial backport of #28416

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_10_6_X.

It involves the following packages:

• SimG4Core/CustomPhysics (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Clean-up Geant4 Physics Lists #28416

[tvami]

@cmsbuild , please test

[tvami]

type bug-fix

[tvami]

urgent

• should go into the CMSSW_10_6_X to be build

[tvami]

(partial) backport of #28416

[tvami]

backport of #28416

[civanch]

+1

I guess it is a correct fix, so sign in advance

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d9de7/21317/summary.html
COMMIT: 19fb7a6
CMSSW: CMSSW_10_6_X_2021-12-13-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36519/21317/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[perrotta]

@tvami where is the configuration SimG4Core/CustomPhysics/python/Exotica_HSCP_SIM_cfi.py used?
Would we touch other sample prodcutions than Tau-prime ones?
Sorry for the questions, but I don't know the structure and I can't easily reconstruct it from the code alone

[civanch]

@perrotta , this fragment is needed to simulate particles, which do not yet discovered. In Geant4 built in only particles, which are seen in experiments and their changes, masses and other quantum numbers are defined in PDG. For any exotica it is needed to add list of extra particles and their interaction on top of Geant4. This is supported within SimG4Core/CustomPhysics sub-library.

[tvami]

Hi @perrotta most of the UL samples use GEN and SIM separately. The EXO samples have a need to do it in one GEN-SIM step, and so the use for these MASS_POINT and SLHA_FILE are restricted to this customization. Well when I say "use", it's a history use, since as you can see it's never consumed in 10_6_X anymore.
Please note that the master is already cleaned of these variables:
https://github.com/cms-sw/cmssw/blob/master/SimG4Core/CustomPhysics/python/Exotica_HSCP_SIM_cfi.py#L6-L9

[perrotta]

+1

• Having got the assurance that the removed parameters are never consumed, and therefore by removing them we won't modify the results of any production ongoing in 10_6, this can get merged